Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] right-click (context) menu extending off screen #3101

Closed
patrick-dojofive opened this issue Apr 25, 2023 · 4 comments
Closed

[BUG] right-click (context) menu extending off screen #3101

patrick-dojofive opened this issue Apr 25, 2023 · 4 comments

Comments

@patrick-dojofive
Copy link

Describe the bug
When I right-click on a transaction that is lower on the screen, the menu anchors on the transaction line and does not adjust its position if it will draw off the bottom of the screen.

To Reproduce
Right-click on a transaction, behavior is quite dependent on where the transaction is on the screen, seems to happen in 3rd quarter from the top of the screen.

Expected behavior
Adjust the position of the menu so that all options can be selected, or at least scroll the menu.

Screenshots
image

Desktop (please complete the following information):

  • OS: Ventura 13.3.1
  • Browser: Chrome Version 112.0.5615.137 (Official Build) (x86_64)
  • Toolkit Version 3.6.0

Setting Export
Please replace the text 'REPLACE_ME_WITH_SETTINGS' below with your exported Toolkit settings. You can export these by going to the Toolkit Options page, click the Import/Export Settings button at the top right and copying the text in the modal which appears.

Note! DO NOT replace the leading and trailing ``` characters as they are required formatting characters.

[{"key":"AccountsDisplayDensity","value":"0"},{"key":"AccountsEmphasizedInflows","value":true},{"key":"AccountsEmphasizedOutflows","value":true},{"key":"AccountsStripedRows","value":true},{"key":"AccountsStripedRowsColor","value":"#fafafa"},{"key":"AccountsStripedRowsDarkColor","value":"#1e1e1f"},{"key":"AssistedClear","value":true},{"key":"AutoDistributeSplits","value":false},{"key":"AutoEnableRunningBalance","value":true},{"key":"AutomaticallyMarkAsCleared","value":false},{"key":"BetterScrollbars","value":"0"},{"key":"BottomNotificationBar","value":false},{"key":"BudgetCategoryFeatures","value":true},{"key":"BudgetProgressBars","value":"0"},{"key":"BudgetQuickSwitch","value":false},{"key":"BudgetSpendingGoal","value":false},{"key":"BulkEditMemo","value":true},{"key":"BulkManagePayees","value":false},{"key":"CalculateIRR","value":false},{"key":"CalendarFirstDay","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"0"},{"key":"CategorySoloMode","value":"0"},{"key":"ChangeEnterBehavior","value":true},{"key":"ChangeMemoEnterBehavior","value":false},{"key":"CheckCreditBalances","value":true},{"key":"CheckNumbers","value":true},{"key":"ClearSelection","value":false},{"key":"CollapseInspector","value":false},{"key":"ColourBlindMode","value":false},{"key":"CompactAccountHeader","value":false},{"key":"CompactIncomeVsExpense","value":true},{"key":"ConfirmEditTransactionCancellation","value":false},{"key":"ConfirmKeyboardCancelationOfTransactionChanges","value":false},{"key":"CreditCardEmoji","value":true},{"key":"CtrlEnterCleared","value":true},{"key":"CurrentMonthIndicator","value":false},{"key":"CustomAverageBudgeting","value":false},{"key":"CustomFlagNames","value":false},{"key":"CustomizeColourScheme","value":true},{"key":"DateOfMoney","value":true},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingDate","value":true},{"key":"DaysOfBufferingExcludeCreditCards","value":false},{"key":"DaysOfBufferingHistoryLookup","value":"0"},{"key":"DefaultCCToCleared","value":false},{"key":"DeselectTransactionsOnSave","value":true},{"key":"DisableToolkit","value":false},{"key":"DisplayMonthlyGoalsOverview","value":false},{"key":"DisplayTargetGoalAmount","value":"0"},{"key":"DisplayTotalMonthlyGoals","value":true},{"key":"DisplayTotalOverspent","value":false},{"key":"DisplayUpcomingAmount","value":true},{"key":"EasyTransactionApproval","value":true},{"key":"EditAccountButton","value":"0"},{"key":"EmphasizeNegativeLoans","value":false},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"FilterCategories","value":true},{"key":"GoalIndicator","value":true},{"key":"GoalWarningColor","value":false},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideAgeOfMoney","value":false},{"key":"HideClosedAccounts","value":true},{"key":"HideDebtRatio","value":false},{"key":"HideHelp","value":false},{"key":"HideReferralBanner","value":true},{"key":"HideTotalAvailable","value":false},{"key":"HighlightNegatives","value":true},{"key":"HoveredBudgetRows","value":false},{"key":"ImportNotification","value":"0"},{"key":"IncomeFromLastMonth","value":"1"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":false},{"key":"LastReconciledDate","value":true},{"key":"LinkToInflows","value":true},{"key":"LiveOnLastMonthsIncome","value":"1"},{"key":"MasterCategoryRowColor","value":false},{"key":"MasterCategoryRowColorSelect","value":"#d1d1d6"},{"key":"MasterCategoryRowDarkColorSelect","value":"#636366"},{"key":"MemoAsMarkdown","value":false},{"key":"MonthlyNotesPopupWidth","value":"0"},{"key":"NavDisplayDensity","value":"0"},{"key":"NotesAsMarkdown","value":false},{"key":"POSStyleCurrencyEntryMode","value":false},{"key":"Pacing","value":"0"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"0"},{"key":"QuickBudgetWarning","value":false},{"key":"ReconcileAssistant","value":true},{"key":"ReconcileBalance","value":true},{"key":"ReconcileConfetti","value":false},{"key":"ReconciledTextColor","value":"0"},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":true},{"key":"ResetColumnWidths","value":true},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"0"},{"key":"RowsHeight","value":"0"},{"key":"SavingsRatio","value":"0.10"},{"key":"ScrollableEditMenu","value":false},{"key":"SeamlessBudgetHeader","value":false},{"key":"SetMultipleFlags","value":false},{"key":"ShowAvailableAfterSavings","value":false},{"key":"ShowCategoryBalance","value":false},{"key":"SpareChange","value":true},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SplitTransactionAutoFillPayee","value":false},{"key":"SplitTransactionTabExpand","value":false},{"key":"SquareNegativeMode","value":true},{"key":"StealingFromFuture","value":true},{"key":"StripedBudgetRows","value":false},{"key":"SubtractUpcomingFromAvailable","value":"0"},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleAccountColumns","value":true},{"key":"ToggleMasterCategories","value":false},{"key":"ToggleSplits","value":true},{"key":"ToggleTransactionFilters","value":"0"},{"key":"ToolkitReports","value":true},{"key":"UnclearedAccountHighlight","value":false},{"key":"ViewZeroAsEmpty","value":true},{"key":"l10n","value":"0"},{"key":"options.dark-mode","value":true}]
@togrady01
Copy link
Contributor

Hi Patrick, there is actually a YNAB Toolkit feature that will scroll the edit menu when it is extending offscreen, however it appears to not be functioning properly, and I think you have it turned off in the settings you pasted.

I'll put up a PR to address this, but I'm not sure it will be able to be included with the next release, but it should be in the follow-on release.

@patrick-dojofive
Copy link
Author

patrick-dojofive commented May 7, 2023 via email

@togrady01
Copy link
Contributor

Under account tab, "Add Scrollbar to Edit Menu".

@joshmadewell
Copy link
Member

Hey @patrick-dojofive the fix for this should be in our current release! If you notice the issue still exists and you're definitely running the newest version of the toolkit, please reopen! Thanks!

Please note, all browser can take up to an hour to provide updates to all users. You can force an update if it's available for you by going to chrome://extensions and clicking the "Update" button. Firefox users can go to about:addons, click the setting cog, and click "Check for updates...".

HelloThisIsFlo pushed a commit to HelloThisIsFlo/toolkit-for-ynab that referenced this issue Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants