fix: #3101 scrollable edit transaction menu & imports fix #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: merge upstream main
joshmadewell
approved these changes
May 7, 2023
HelloThisIsFlo
pushed a commit
to HelloThisIsFlo/toolkit-for-ynab
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #3101
Explanation of Bugfix/Feature/Modification:
Edit transaction menu add scroll bar feature was not working.
Additionally, a PR merged changed the YNABModalService type from interface to type, and we needed to update some imports as a result. That is addressed with this PR.