fix: adapt multiple features to glimmer #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 8, 2022
joshmadewell
reviewed
Oct 8, 2022
Comment on lines
+43
to
+46
| invoke() { | ||
| // | ||
| } | ||
|
|
There was a problem hiding this comment.
re: discussion in slack - can we update the shouldInvoke for all of these to return if we're on the appropriate page and then actually update invoke
fwiw, this one should probably return false in shouldInvoke since there's nothing happening in invoke
This was
linked to
issues
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #2955 #2959 #2956 #2963
Trello Link (if applicable):
Explanation of Bugfix/Feature/Modification:
Fixes multiple features after YNAB's move to glimmer