Update memdown to v1.4.1 and update test suite #5
Conversation
This commit brings make this compliant with the latest Level ecosystem, using memdown 1.4.1 (which uses abstract-leveldown v2.7). It is an overall due to how memdown uses Red Black Trees as internal data structure, this package had to adapt in order to (de)serialize those trees. The test suite comes from the standard abstract-leveldown test suite, using tape as test runner.
|
Oh thanks! I'll take a look at this soon! |
| var niceStringify = require('./nice-stringify'); | ||
| function serializeStore(store) { | ||
| var result = {}; | ||
| Object.keys(store).forEach(location => { |
There was a problem hiding this comment.
The tests are failing on Travis because it's running with Node 0.10.0. You should either update the .travis.yml file to a later Node version or remove the arrow functions (this one and the one on line 11)
There was a problem hiding this comment.
Oh geez, I wrote this a billion years ago. I'm fine with upgrading the version of Node that this package expects--I assume this would involve not only updating .travis.yml, but also adding something to package.json indicating the version of node that's needed?
|
This PR looks nice to me, though I'm unfamiliar with memdown's use of Red Black Trees. As long as Travis is updated to run the tests properly, and |
|
When this is merged it would be good to update https://github.com/Level/awesome/#stores as well to indicate that |
|
Updated the Travis config to use a long-term support version of Node.js. :) |
|
Woot thanks!! I'm going to merge this now, but I think it still needs to be published on npm, right? I haven't done that in a really long time but I will give it a shot. Alternatively, @staltz or @emschwartz, are either of you interested in becoming maintainers of this project? No worries if not, I figured I might as well ask. |
|
Up to you, you can add me as a maintainer if you'd like and I can publish it to NPM |
|
Hi! Thanks for merging. I can also be a maintainer. In fact I already published my fork as the package |
|
Sure thing, just added you @staltz ! |
|
Version 1.0.0 released! :) |
Since this PR: toolness/jsondown#5
Since this PR: toolness/jsondown#5
Since this PR: toolness/jsondown#5
This commit make this package compliant with the latest Level ecosystem,
using memdown 1.4.1 (which uses abstract-leveldown v2.7). It is an
overhaul due to how memdown uses Red Black Trees as internal data
structure, this package had to adapt in order to (de)serialize those
trees.
The test suite comes from the standard abstract-leveldown test suite,
using tape as test runner.