[potential bug] When running <leader>te (task edit) I seem to open a vim instance within an vim instance #193

arooni · 2018-10-21T23:09:16Z

env: ubuntu 18.04 with latest task warrior and taskwii

Use case:
I have taskwiki open as a buffer along with other buffers for my personal journal/notes file.

i select a task i want to edit
te
i see the edit screen; but its kinda like a vim within a vim window (attached screenshot so you could see what i see).
as i try to scroll i can only scroll in the outward vim instance not in the vim instance that contains fields to edit in
unable to edit file and in addition task warrior locks it creating a file in ~/.task so it can't be edited till i delete that file.

ideas? what am i doing wrong? thanks!

tbabej · 2018-10-22T20:03:59Z

Are you using vim or neovim?

arooni · 2018-10-26T23:44:19Z

neovim

tbabej · 2019-01-25T03:21:20Z

Does this issue still persist? I am able to perform :TaskWikiEdit in neovim just fine. Can you post your nvim --version?

mgoral · 2019-03-25T12:47:31Z

@arooni Taskwiki opens new neovim inside terminal buffer (:h terminal), but this buffer starts in original neovim's normal mode (try e.g. :term - you can freely navigate that buffer like all other buffers in neovim). To enter terminal mode, you have to access to the "inner" neovim, e.g. by pressing a. Then you'll be inside the inner neovim, which starts in its own normal mode, so to edit its buffer (the one with loaded task), you have enter insert mode (e.g. once again a). Now when you exit the inner neovim, Taskwarrior will detect your changes, automatically remove all temporary files and everything works like expected. Also the outer's terminal buffer is automatically deleted and the original wiki file is displayed.

I think that neovim 0.1.x automatically started terminal buffers in terminal mode and that it changed for 0.2+, so maybe that's where confusion comes from?

arooni · 2019-03-28T17:48:45Z

@tbabej

[I]  ~  nvim --version
NVIM v0.3.4
Build type: Release
LuaJIT 2.0.5
Compilation: /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/tmp/neovim-20190113-94620-d8vv4n/neovim-0.3.4/build/config -I/tmp/neovim-20190113-94620-d8vv4n/neovim-0.3.4/src -I/usr/local/include -I/usr/local/opt/gettext/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include -I/tmp/neovim-20190113-94620-d8vv4n/neovim-0.3.4/build/src/nvim/auto -I/tmp/neovim-20190113-94620-d8vv4n/neovim-0.3.4/build/include
Compiled by brew@Mojave.local

Features: +acl +iconv +jemalloc +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.3.4/share/nvim"

Run :checkhealth for more info

@mgoral
So you're saying I need to run :term before running taskwiki?

mgoral · 2019-03-28T18:34:22Z

No, taskwiki does that automatically. I'm just saying that there is a nested vim inside the original vim, so to access it and edit the task you have to press 'a' twice. :) Dnia 28 marca 2019 18:48:46 CET, arooni <notifications@github.com> napisał(a):

…

@tbabej > ```> [I] ~  nvim --version> NVIM v0.3.4> Build type: Release> LuaJIT 2.0.5> Compilation: /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/tmp/neovim-20190113-94620-d8vv4n/neovim-0.3.4/build/config -I/tmp/neovim-20190113-94620-d8vv4n/neovim-0.3.4/src -I/usr/local/include -I/usr/local/opt/gettext/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include -I/tmp/neovim-20190113-94620-d8vv4n/neovim-0.3.4/build/src/nvim/auto -I/tmp/neovim-20190113-94620-d8vv4n/neovim-0.3.4/build/include> Compiled by ***@***.***> > Features: +acl +iconv +jemalloc +tui> See ":help feature-compile"> > system vimrc file: "$VIM/sysinit.vim"> fall-back for $VIM: "/usr/local/Cellar/neovim/0.3.4/share/nvim"> > Run :checkhealth for more info> > ```> > @mgoral > So you're saying I need to run :term before running taskwiki?> > -- > You are receiving this because you were mentioned.> Reply to this email directly or view it on GitHub:> #193 (comment)

arooni · 2019-03-28T19:53:58Z

If I have a task selected, and then run :TaskWikiEdit

It errors out:

Error detected while processing function <SNR>131_LoadRemotePlugins[1]..<SNR>131_GetManifest[1]..<SNR>131_GetManifestPath:
line    7:
E117: Unknown function: stdpath
Press ENTER or type command to continue
 NORMAL  SPELL [EN]  term://.//38645:task  b30d07a6 edit[-]                                                                                                                    [unix]    2%    1/45  :  1 
:TaskWikiEdit

Not sure if that's a different plugin that's getting in the way

jean · 2020-02-17T10:55:03Z

I'm seeing the same thing:

Launching 'vim "task.1f82c8a5.task"' now...
Error detected while processing function <SNR>13_LoadRemotePlugins[1]..<SNR>13_GetManifest[1]..<SNR>13_GetManifestPath:
line    7:
E117: Unknown function: stdpath
E15: Invalid expression: stdpath('data')                                                                                                                                                                                                                                                                                      
Press ENTER or type command to continue

It looks like it's trying to launch vim instead of nvim?

tbabej · 2020-02-17T18:39:21Z

This is happening in the taskwarrior itself, we are only launching the task edit command through taskwiki. The task edit uses the editor that is defined via your $EDITOR env variable.

arooni · 2020-02-18T23:36:57Z

i set and verified that the editor variable was set to nvim; but after running task edit i still get an error:

[I]  ~  echo $EDITOR
nvim
[I]  ~ 

Error detected while processing function <SNR>134_LoadRemotePlugins[1]..<SNR>134_GetManifest[1]..<SNR>134_GetManifestPath:
line    7:
E117: Unknown function: stdpath
Press ENTER or type command to continue
 NORMAL  term://.//54443:task  d649e19c edit[-]                                                                                                                                 [unix]    2%    1/46  :  1 

tbabej · 2020-02-18T23:39:26Z

I'm not sure this is related to taskwiki though, a quick google search showcases this error discussed in various scenarios,i.e.:

neovim/neovim#9960

arooni · 2020-02-18T23:42:42Z

fair point.

arooni · 2020-02-18T23:54:58Z

setting editor to nvim seeed to help quite a bit. but on some tasks i see:

Filter: ( ( ( uuid = 9a498c82 ) ) )
Task is already being edited.

[Process exited 2]

even though there are no other nvim or taskwarrior processes. any insight to this?

tbabej · 2020-02-19T00:01:04Z

If you poke in the sources of Taskwarrior, in CmdEdit.cpp you can see that this is being raised if the filename for editing the task already exists:

  // Check if the file already exists, if so, bail out
  Path filepath = Path (file.str ());
  if (filepath.exists ())
    throw std::string ("Task is already being edited.");

So the fix here is to simply clean your ~/.task directory and make sure there are no *.task files there.

arooni · 2020-02-19T00:09:11Z

@tbabej makes sense; it seems right now the only way to not get these extra *.task files is to use :q! which seems to terminate the whole nvim enterprise, not just the inner invocation used for taskwarrior.

so is there a best practice other than quitting out of nvim after each task edit?

definitely not trying to be a help vampire and i appreciate your help.

arooni · 2020-02-19T00:14:18Z

i.e. how to quit out of the inner layer of task warrior (the edit screen) without quitting out of nvim completely

aaronfc · 2020-03-05T09:55:51Z

Setting the EDITOR environment variable didn't work for me. I ended up adding:

editor=nvim

to the ~/.taskrc file.

arooni · 2020-03-05T23:42:13Z

@aaronfc any way to quit out of the embedded editor window if you decide you don't want to make changes? i run :q and it seems to run the containing taskwarrior window. running :bd simply kills the buffer and taskwarrior keeps *.task files in my ~/.taskwarrior directory that prevent me from editing the same task again until I clear them out.

finally running :wq or :wq! from inside the editor (with no changes) shows "E382: Cannot write, 'buftype' option is set"

aaronfc · 2020-03-29T16:33:22Z

@arooni You have first to go into insert mode (press i) and then you can quit by :q.

arooni · 2020-03-29T22:15:07Z

@aaronfc thanks so much for breaking that down!

tmerse · 2021-01-03T09:59:49Z

@arooni autocmd TermOpen * startinsert may safe you some typing aswell.

maxksec · 2022-06-09T12:39:41Z

Not sure if it is relevant yet, but I could not make it work with the previous suggestions. Ended up doing the following:

install neovim remote

pip3 install neovim-remote

sudo touch /usr/local/bin/nested-nvim
sudo chmod +x /usr/local/bin/nested-nvim

the contents of the file:

#!/bin/bash
if [ -n "$NVIM_LISTEN_ADDRESS" ]; then
  nvr -cc tabedit --remote-wait +'set bufhidden=wipe' "$@"
else
  "nvim" "$@"
fi

in .bashrc or .zshrc add

export VISUAL=nested-nvim
alias v="$VISUAL"
alias vim="$VISUAL"

reload shell

and after that the edit worked in place for me :)

tbabej closed this as completed Feb 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[potential bug] When running <leader>te (task edit) I seem to open a vim instance within an vim instance #193

[potential bug] When running <leader>te (task edit) I seem to open a vim instance within an vim instance #193

arooni commented Oct 21, 2018

tbabej commented Oct 22, 2018

arooni commented Oct 26, 2018

tbabej commented Jan 25, 2019

mgoral commented Mar 25, 2019 •

edited

Loading

arooni commented Mar 28, 2019

mgoral commented Mar 28, 2019 via email

arooni commented Mar 28, 2019

jean commented Feb 17, 2020

tbabej commented Feb 17, 2020

arooni commented Feb 18, 2020 •

edited

Loading

tbabej commented Feb 18, 2020

arooni commented Feb 18, 2020

arooni commented Feb 18, 2020

tbabej commented Feb 19, 2020

arooni commented Feb 19, 2020

arooni commented Feb 19, 2020

aaronfc commented Mar 5, 2020 •

edited

Loading

arooni commented Mar 5, 2020 •

edited

Loading

aaronfc commented Mar 29, 2020 •

edited

Loading

arooni commented Mar 29, 2020

tmerse commented Jan 3, 2021

maxksec commented Jun 9, 2022 •

edited

Loading

[potential bug] When running <leader>te (task edit) I seem to open a vim instance within an vim instance #193

[potential bug] When running <leader>te (task edit) I seem to open a vim instance within an vim instance #193

Comments

arooni commented Oct 21, 2018

tbabej commented Oct 22, 2018

arooni commented Oct 26, 2018

tbabej commented Jan 25, 2019

mgoral commented Mar 25, 2019 • edited Loading

arooni commented Mar 28, 2019

mgoral commented Mar 28, 2019 via email

arooni commented Mar 28, 2019

jean commented Feb 17, 2020

tbabej commented Feb 17, 2020

arooni commented Feb 18, 2020 • edited Loading

tbabej commented Feb 18, 2020

arooni commented Feb 18, 2020

arooni commented Feb 18, 2020

tbabej commented Feb 19, 2020

arooni commented Feb 19, 2020

arooni commented Feb 19, 2020

aaronfc commented Mar 5, 2020 • edited Loading

arooni commented Mar 5, 2020 • edited Loading

aaronfc commented Mar 29, 2020 • edited Loading

arooni commented Mar 29, 2020

tmerse commented Jan 3, 2021

maxksec commented Jun 9, 2022 • edited Loading

mgoral commented Mar 25, 2019 •

edited

Loading

arooni commented Feb 18, 2020 •

edited

Loading

aaronfc commented Mar 5, 2020 •

edited

Loading

arooni commented Mar 5, 2020 •

edited

Loading

aaronfc commented Mar 29, 2020 •

edited

Loading

maxksec commented Jun 9, 2022 •

edited

Loading