Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix build of psutil (required by pytest-xdist 2.0) #300

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

liskin
Copy link
Collaborator

@liskin liskin commented Aug 24, 2020

@liskin
Copy link
Collaborator Author

liskin commented Aug 24, 2020

Maybe I should also comment out 2.5.2 until I find the time to investigate this. It makes all commits and pull requests to be marked as ❌ which makes the tests status icons useless. What do you think?

@tbabej
Copy link
Collaborator

tbabej commented Sep 18, 2020

@liskin I'd normally agree, but 2.5.2 is technically last released stable version. I'll look into the issue.

@tbabej tbabej merged commit a9af182 into tools-life:master Sep 18, 2020
@liskin liskin deleted the pr/tests branch September 18, 2020 06:54
@liskin
Copy link
Collaborator Author

liskin commented Sep 18, 2020

@tbabej Not really a "last released stable version", more like a "stable branch that may never see another release again".

Anyway, do we keep the continue-on-error: true now that 2.5.2 is fixed (but see GothenburgBitFactory/taskwarrior@10b64ad#commitcomment-42421819)?

continue-on-error: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants