This repository has been archived by the owner on Feb 26, 2019. It is now read-only.
Pulling in cmd/go and accessing it directly instead of via exec #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkautz
changed the title
fkautz
changed the title
|
Looks like this issue was fixed in go1.5 due to golang/go#10509 Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, in this patch, we pull in cmd/go, make go get private methods public, do a lot of tree shaking (we don't need all cmd/go), and make godep use those new public methods with some minor fixes (like not checking directory for buildable files before reverting to older commit). :)