Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

Pulling in cmd/go and accessing it directly instead of via exec #196

Closed
wants to merge 11 commits into from

Conversation

fkautz
Copy link

@fkautz fkautz commented Mar 24, 2015

So, in this patch, we pull in cmd/go, make go get private methods public, do a lot of tree shaking (we don't need all cmd/go), and make godep use those new public methods with some minor fixes (like not checking directory for buildable files before reverting to older commit). :)

@fkautz fkautz changed the title More pruning Pulling in go/tools and accessing it directly instead of via exec Mar 24, 2015
@fkautz fkautz changed the title Pulling in go/tools and accessing it directly instead of via exec Pulling in cmd/go and accessing it directly instead of via exec Mar 24, 2015
@fkautz
Copy link
Author

fkautz commented Apr 2, 2015

@kr Does this patch make sense, based on what we spoke about before? If not, I can try submitting a different approach to fix #186.

@fkautz
Copy link
Author

fkautz commented Jun 19, 2015

Looks like this issue was fixed in go1.5 due to golang/go#10509

Closing.

@fkautz fkautz closed this Jun 19, 2015
@kr kr deleted the pr_out_more_pruning branch June 20, 2015 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant