Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three Dot Menu in Posts still not working #451

Closed
scottiefalkon opened this issue Nov 10, 2022 · 27 comments
Closed

Three Dot Menu in Posts still not working #451

scottiefalkon opened this issue Nov 10, 2022 · 27 comments
Assignees
@xmflsct
Labels
_android bug

Comments

@scottiefalkon
Copy link

I know we discussed this before. You said you can't reproduce it in the emulator. On the newest version of tooot and the latest version of Android 13 on Pixel 6 Pro, tapping the "..." in a post does nothing. Neither in timeline view or in a post itself. I even did a clean install the other night of the entire OS. It's not any setting on my end. I'd like to help resolve. What can I do to help?
@thigger
Copy link

thigger commented Nov 11, 2022

Reproducible here (Galaxy S21, Android 12) - though if I keep tapping I can sometimes get it to work. I have my font size set to the smallest in Android and screen zoom also at the smallest if that's relevant. Font size in the app is set to "M - default"

@xmflsct xmflsct self-assigned this Nov 11, 2022
@jesuscovam jesuscovam mentioned this issue Nov 11, 2022
Closed
@xmflsct
Copy link
Member

xmflsct commented Nov 11, 2022

@scottiefalkon I am hoping to push a test version in few days. By then there will be an apk available on GitHub that you can try it out and let me know if it works!

xmflsct added a commit that referenced this issue Nov 12, 2022
@xmflsct @jsoref
Test updates (#456)
641e1f0 
* Build succeeded

* Fix RN update caused Android build error

Spent whole fucking 2 days to figure this out facebook/react-native#35210

* Fixed #408

Potentially because of too small pressable area

* Fixed #439

* Bump up RN and Expo

* Fixed #450

* Spelling (#449)

* spelling: announcement

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: corrupted

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: dimensions

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: favourites

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: mutation

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: retrieve

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: transitive

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* Fixed #451

More properly adjusted flexbox layout

* Partial fix of #444

It is possible to implement what the web does but that adds additional resources which I believe is not justified. Filtering is meant to be precise. Even hiding the entire block that you still would like to take a look at the content, then why would you set up a certain filter then.

Though showing the matched filter is still useful.

* New Crowdin updates (#440)

* New translations tabs.json (German)

* New translations tabs.json (Italian)

* New translations tabs.json (Japanese)

* New translations tabs.json (Korean)

* New translations tabs.json (Chinese Simplified)

* New translations tabs.json (Chinese Traditional)

* New translations tabs.json (Vietnamese)

* New translations tabs.json (Portuguese, Brazilian)

* New translations tabs.json (Chinese Simplified)

* New translations instance.json (German)

* New translations parse.json (German)

* New translations timeline.json (German)

* New translations mediaSelector.json (German)

* New translations emojis.json (German)

* New translations contextMenu.json (German)

* New translations actions.json (German)

* New translations compose.json (German)

* New translations accountSelection.json (German)

* New translations timeline.json (German)

* New translations contextMenu.json (German)

* New translations actions.json (German)

* New translations compose.json (German)

* New translations tabs.json (German)

* New translations screens.json (German)

* New translations common.json (French)

* New translations instance.json (French)

* New translations parse.json (French)

* New translations relationship.json (French)

* New translations timeline.json (French)

* New translations actions.json (French)

* New translations imageViewer.json (French)

* New translations announcements.json (French)

* New translations compose.json (French)

* New translations screens.json (French)

* New translations tabs.json (French)

* New translations mediaSelector.json (French)

* New translations emojis.json (French)

* New translations contextMenu.json (French)

* New translations accountSelection.json (French)

* New translations actions.json (French)

* New translations announcements.json (French)

* New translations compose.json (French)

* New translations accountSelection.json (French)

* New translations instance.json (French)

* New translations parse.json (French)

* New translations relationship.json (French)

* New translations timeline.json (French)

* New translations imageViewer.json (French)

* New translations compose.json (French)

* New translations tabs.json (French)

* New translations mediaSelector.json (French)

* New translations emojis.json (French)

* New translations contextMenu.json (French)

* New translations common.json (French)

* New translations compose.json (French)

* New translations screens.json (French)

* New translations tabs.json (French)

* New translations contextMenu.json (French)

* New translations common.json (French)

* New translations instance.json (French)

* Added French translation 🇫🇷

* Fixed #454

* Fixed #443

Basically matching all none whitespace characters

* Fixed #446

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@scottiefalkon
Copy link
Author

Thank you. Will do.

@xmflsct
Copy link
Member

xmflsct commented Nov 14, 2022

@scottiefalkon forgot that I have removed the testing APK builds a while back. Just released 4.6.0. You can find the apk in the release. Let me know if it has been fixed!

@scottiefalkon
Copy link
Author

@scottiefalkon forgot that I have removed the testing APK builds a while back. Just released 4.6.0. You can find the apk in the release. Let me know if it has been fixed!

The issue remains. I noticed someone posted a recent review that is experiencing the issue as well. Wish I knew the answer.

@xmflsct
Copy link
Member

xmflsct commented Nov 15, 2022

@scottiefalkon with 4.6.0, are you able to trigger the three dot menu every now and then, or it is not possible to trigger it at all?

@xmflsct xmflsct reopened this Nov 15, 2022
@scottiefalkon
Copy link
Author

@scottiefalkon with 4.6.0, are you able to trigger the three dot menu every now and then, or it is not possible to trigger it at all?

It won't trigger at all. Same as before.

@xmflsct
Copy link
Member

xmflsct commented Nov 15, 2022

Okay so it is not a touch target issue in this case.

@scottiefalkon
Copy link
Author

scottiefalkon commented Nov 15, 2022 via email

@leohearts
Copy link

Maybe the reason is onLongPress={() => null} in <Pressable> above <ContextMenu> ?
This makes the three dot menu not triggering even if user move 1px on their finger when touching.
I can only trigger the context menu only when using a mouse or pressing it very carefully.

@xmflsct
Copy link
Member

xmflsct commented Nov 18, 2022

@leohearts I don't think so, that line was added in the latest release v4.6.1 to see if that may solve the problem ce0adee.

I believe it is due to how the layout API has been implemented differently on different Android systems. In the emulator which is based on Google's official interpretation of Android, the current touch target is huge, the same as on iOS. But it may be somehow not rendered in the way it is intended.

If v4.6.1 is still not working for you and others, I have to change the Android specific code to use another approach, which is fine, just a bit annoying to maintain different codes for different systems, which is not the intention of React Native.

@scottiefalkon
Copy link
Author

scottiefalkon commented Nov 18, 2022 via email

@unixninja92
Copy link

I'm on a pixel 5a. The button worked the first two times I hit it right after opening the app for the first time in a while but hasn't worked since. I'm on 4.6.1.

@xmflsct
Copy link
Member

xmflsct commented Nov 19, 2022

Forgot to ask, does the three dot work in the User/Account page?

image

@unixninja92
Copy link

The three dots on account pages work just fine.

@xmflsct
Copy link
Member

xmflsct commented Nov 19, 2022

@unixninja92 Thank you, this is helpful!

@scottiefalkon
Copy link
Author

scottiefalkon commented Nov 20, 2022 via email

@xmflsct xmflsct reopened this Nov 20, 2022
@xmflsct xmflsct mentioned this issue Nov 20, 2022
Closed
@xmflsct
Copy link
Member

xmflsct commented Nov 21, 2022

v4.6.2 released hoping it would be possible to address this issue. Would any of you like to try it out and let me know? Thanks!

@scottiefalkon
Copy link
Author

scottiefalkon commented Nov 21, 2022 via email

@thigger
Copy link

thigger commented Nov 21, 2022

Sorry, similar here. I can trigger it but only on about 1 in 10 presses (if anything it seems to be triggering less frequently than before). Galaxy S21, Android 12, tooot 4.6.2 (Play Store)

@ottomano
Copy link

Same problem here on 4.6.2 (Xiaomi Mi A2 Lite, Android 10).

Please notice that Tooot app has disappeared from google play.

@scottiefalkon
Copy link
Author

scottiefalkon commented Nov 21, 2022 via email

@xmflsct
Copy link
Member

xmflsct commented Nov 21, 2022

Because Play Store's staff also could not click the menu in order to test blocking accounts..

@scottiefalkon
Copy link
Author

scottiefalkon commented Nov 21, 2022 via email

@ottomano
Copy link

ottomano commented Nov 22, 2022 •
edited
Loading

v4.6.2 released hoping it would be possible to address this issue. Would any of you like to try it out and let me know? Thanks!

Since the issue is still present on 4.6.2, if you would like to test a 4.6.3 beta version of the APK, I'm available to try it in order to see if the fix is properly working.

@scottiefalkon
Copy link
Author

scottiefalkon commented Nov 22, 2022 via email

@xmflsct xmflsct mentioned this issue Nov 22, 2022
Closed
@scottiefalkon
Copy link
Author

Fixed! Fantastic. Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xmflsct xmflsct

Labels
_android bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added increased hitSlot to fix #451 jesuscovam/tooot-app
6 participants
@xmflsct @unixninja92 @thigger @leohearts @ottomano @scottiefalkon