-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extract counters from accounts table to account_stats table (#9295)
- Loading branch information
Showing
25 changed files
with
203 additions
and
68 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# frozen_string_literal: true | ||
|
||
# == Schema Information | ||
# | ||
# Table name: account_stats | ||
# | ||
# id :bigint(8) not null, primary key | ||
# account_id :bigint(8) not null | ||
# statuses_count :bigint(8) default(0), not null | ||
# following_count :bigint(8) default(0), not null | ||
# followers_count :bigint(8) default(0), not null | ||
# created_at :datetime not null | ||
# updated_at :datetime not null | ||
# | ||
|
||
class AccountStat < ApplicationRecord | ||
belongs_to :account, inverse_of: :account_stat | ||
|
||
def increment_count!(key) | ||
update(key => public_send(key) + 1) | ||
end | ||
|
||
def decrement_count!(key) | ||
update(key => [public_send(key) - 1, 0].max) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# frozen_string_literal: true | ||
|
||
module AccountCounters | ||
extend ActiveSupport::Concern | ||
|
||
included do | ||
has_one :account_stat, inverse_of: :account | ||
after_save :save_account_stat | ||
end | ||
|
||
delegate :statuses_count, | ||
:statuses_count=, | ||
:following_count, | ||
:following_count=, | ||
:followers_count, | ||
:followers_count=, | ||
:increment_count!, | ||
:decrement_count!, | ||
to: :account_stat | ||
|
||
def account_stat | ||
super || build_account_stat | ||
end | ||
|
||
private | ||
|
||
def save_account_stat | ||
return unless account_stat&.changed? | ||
account_stat.save | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
class CreateAccountStats < ActiveRecord::Migration[5.2] | ||
def change | ||
create_table :account_stats do |t| | ||
t.belongs_to :account, null: false, foreign_key: { on_delete: :cascade }, index: { unique: true } | ||
t.bigint :statuses_count, null: false, default: 0 | ||
t.bigint :following_count, null: false, default: 0 | ||
t.bigint :followers_count, null: false, default: 0 | ||
|
||
t.timestamps | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
class CopyAccountStats < ActiveRecord::Migration[5.2] | ||
disable_ddl_transaction! | ||
|
||
def up | ||
safety_assured do | ||
if supports_upsert? | ||
up_fast | ||
else | ||
up_slow | ||
end | ||
end | ||
end | ||
|
||
def down | ||
# Nothing | ||
end | ||
|
||
private | ||
|
||
def supports_upsert? | ||
version = select_one("SELECT current_setting('server_version_num') AS v")['v'].to_i | ||
version >= 90500 | ||
end | ||
|
||
def up_fast | ||
say 'Upsert is available, importing counters using the fast method' | ||
|
||
Account.unscoped.select('id').find_in_batches(batch_size: 5_000) do |accounts| | ||
execute <<-SQL.squish | ||
INSERT INTO account_stats (account_id, statuses_count, following_count, followers_count, created_at, updated_at) | ||
SELECT id, statuses_count, following_count, followers_count, created_at, updated_at | ||
FROM accounts | ||
WHERE id IN (#{accounts.map(&:id).join(', ')}) | ||
ON CONFLICT (account_id) DO UPDATE | ||
SET statuses_count = EXCLUDED.statuses_count, following_count = EXCLUDED.following_count, followers_count = EXCLUDED.followers_count | ||
SQL | ||
end | ||
end | ||
|
||
def up_slow | ||
say 'Upsert is not available in PostgreSQL below 9.5, falling back to slow import of counters' | ||
|
||
# We cannot use bulk INSERT or overarching transactions here because of possible | ||
# uniqueness violations that we need to skip over | ||
Account.unscoped.select('id, statuses_count, following_count, followers_count, created_at, updated_at').find_each do |account| | ||
begin | ||
params = [[nil, account.id], [nil, account.statuses_count], [nil, account.following_count], [nil, account.followers_count], [nil, account.created_at], [nil, account.updated_at]] | ||
exec_insert('INSERT INTO account_stats (account_id, statuses_count, following_count, followers_count, created_at, updated_at) VALUES ($1, $2, $3, $4, $5, $6)', nil, params) | ||
rescue ActiveRecord::RecordNotUnique | ||
next | ||
end | ||
end | ||
end | ||
end |
Oops, something went wrong.