-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost and toot deletion interaction problem #889
Comments
Okay, I can see this being problematic. Thank you for taking the time to test this. Off the top of my head it's probably because the "delete" notification is sent to all followers of the original author. The receivers of that "delete" remove the toot/boost. But do not forward the "delete" even further in case of boosts. A special case for such forwarding needs to be added. |
I have confirmed that my above assesment is incorrect. Save for network failures, a delete propagates, deleting reblogs of itself, spreading the deletes further. There were some causality related issues with deletes that were fixed since this issue was opened. Perhaps it's no longer a problem. |
I think this problem still exists on 1.5.1. Even now, only ways to delete status from remote instance are a) push to subscribers b) salmon to mentioned accounts. Subscribers of the user who boosted will receive those "delete" message for boost itself, but not for boosted status. |
* Deliver ActivityPub Like * Deliver ActivityPub Undo-Like * Deliver ActivityPub Create/Announce activities * Deliver ActivityPub creates from mentions * Deliver ActivityPub Block/Undo-Block * Deliver ActivityPub Accept/Reject-Follow * Deliver ActivityPub Undo-Follow * Deliver ActivityPub Follow * Deliver ActivityPub Delete activities Incidentally fix #889 * Adjust BatchedRemoveStatusService for ActivityPub * Add tests for ActivityPub workers * Add tests for FollowService * Add tests for FavouriteService, UnfollowService and PostStatusService * Add tests for ReblogService, BlockService, UnblockService, ProcessMentionsService * Add tests for AuthorizeFollowService, RejectFollowService, RemoveStatusService * Add tests for BatchedRemoveStatusService * Deliver updates to a local account to ActivityPub followers * Minor adjustments
Merge upstream changes (v2.7.0)
Boosting a toot may result in bug in his deletion in some case
@Sp3r4z@mastodon.xyz, @corzntin@anticapitalist.party and I (@s18alg@hostux.social) made some test on multi-instance configuration
Reproduce :
after that Corzntin can still see the deleted toot, but I can't
This doesn't look critical, and may likely be a bug comming from instance configuration, but I submit it since it may become a privacy issue.
The text was updated successfully, but these errors were encountered: