Boost and toot deletion interaction problem #889

Closed
SuliacLEGUILLOU opened this Issue Apr 4, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@SuliacLEGUILLOU

Boosting a toot may result in bug in his deletion in some case

@Sp3r4z@mastodon.xyz, @corzntin@anticapitalist.party and I (@s18alg@hostux.social) made some test on multi-instance configuration

Reproduce :

  • sp3r4z post a toot
  • I boost it, then Corzntin boost it
  • sp3r4z boost his own toot
  • sp3r4z delete the toot

after that Corzntin can still see the deleted toot, but I can't
This doesn't look critical, and may likely be a bug comming from instance configuration, but I submit it since it may become a privacy issue.


  • [ x ] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@Gargron

This comment has been minimized.

Show comment
Hide comment
@Gargron

Gargron Apr 4, 2017

Member

Okay, I can see this being problematic. Thank you for taking the time to test this. Off the top of my head it's probably because the "delete" notification is sent to all followers of the original author. The receivers of that "delete" remove the toot/boost. But do not forward the "delete" even further in case of boosts. A special case for such forwarding needs to be added.

Member

Gargron commented Apr 4, 2017

Okay, I can see this being problematic. Thank you for taking the time to test this. Off the top of my head it's probably because the "delete" notification is sent to all followers of the original author. The receivers of that "delete" remove the toot/boost. But do not forward the "delete" even further in case of boosts. A special case for such forwarding needs to be added.

@ashfurrow ashfurrow added the bug label Apr 22, 2017

@Gargron

This comment has been minimized.

Show comment
Hide comment
@Gargron

Gargron Jun 29, 2017

Member

I have confirmed that my above assesment is incorrect. Save for network failures, a delete propagates, deleting reblogs of itself, spreading the deletes further. There were some causality related issues with deletes that were fixed since this issue was opened. Perhaps it's no longer a problem.

Member

Gargron commented Jun 29, 2017

I have confirmed that my above assesment is incorrect. Save for network failures, a delete propagates, deleting reblogs of itself, spreading the deletes further. There were some causality related issues with deletes that were fixed since this issue was opened. Perhaps it's no longer a problem.

@Gargron Gargron closed this Jun 29, 2017

@unarist

This comment has been minimized.

Show comment
Hide comment
@unarist

unarist Aug 7, 2017

Collaborator

I think this problem still exists on 1.5.1. Even now, only ways to delete status from remote instance are a) push to subscribers b) salmon to mentioned accounts. Subscribers of the user who boosted will receive those "delete" message for boost itself, but not for boosted status.

Collaborator

unarist commented Aug 7, 2017

I think this problem still exists on 1.5.1. Even now, only ways to delete status from remote instance are a) push to subscribers b) salmon to mentioned accounts. Subscribers of the user who boosted will receive those "delete" message for boost itself, but not for boosted status.

Gargron added a commit that referenced this issue Aug 10, 2017

Gargron added a commit that referenced this issue Aug 11, 2017

Gargron added a commit that referenced this issue Aug 12, 2017

ActivityPub delivery (#4566)
* Deliver ActivityPub Like

* Deliver ActivityPub Undo-Like

* Deliver ActivityPub Create/Announce activities

* Deliver ActivityPub creates from mentions

* Deliver ActivityPub Block/Undo-Block

* Deliver ActivityPub Accept/Reject-Follow

* Deliver ActivityPub Undo-Follow

* Deliver ActivityPub Follow

* Deliver ActivityPub Delete activities

Incidentally fix #889

* Adjust BatchedRemoveStatusService for ActivityPub

* Add tests for ActivityPub workers

* Add tests for FollowService

* Add tests for FavouriteService, UnfollowService and PostStatusService

* Add tests for ReblogService, BlockService, UnblockService, ProcessMentionsService

* Add tests for AuthorizeFollowService, RejectFollowService, RemoveStatusService

* Add tests for BatchedRemoveStatusService

* Deliver updates to a local account to ActivityPub followers

* Minor adjustments

YaQ00 added a commit to YaQ00/mastodon that referenced this issue Sep 5, 2017

ActivityPub delivery (#4566)
* Deliver ActivityPub Like

* Deliver ActivityPub Undo-Like

* Deliver ActivityPub Create/Announce activities

* Deliver ActivityPub creates from mentions

* Deliver ActivityPub Block/Undo-Block

* Deliver ActivityPub Accept/Reject-Follow

* Deliver ActivityPub Undo-Follow

* Deliver ActivityPub Follow

* Deliver ActivityPub Delete activities

Incidentally fix #889

* Adjust BatchedRemoveStatusService for ActivityPub

* Add tests for ActivityPub workers

* Add tests for FollowService

* Add tests for FavouriteService, UnfollowService and PostStatusService

* Add tests for ReblogService, BlockService, UnblockService, ProcessMentionsService

* Add tests for AuthorizeFollowService, RejectFollowService, RemoveStatusService

* Add tests for BatchedRemoveStatusService

* Deliver updates to a local account to ActivityPub followers

* Minor adjustments

39e added a commit to Arukas/mastodon that referenced this issue Sep 8, 2017

ActivityPub delivery (#4566)
* Deliver ActivityPub Like

* Deliver ActivityPub Undo-Like

* Deliver ActivityPub Create/Announce activities

* Deliver ActivityPub creates from mentions

* Deliver ActivityPub Block/Undo-Block

* Deliver ActivityPub Accept/Reject-Follow

* Deliver ActivityPub Undo-Follow

* Deliver ActivityPub Follow

* Deliver ActivityPub Delete activities

Incidentally fix #889

* Adjust BatchedRemoveStatusService for ActivityPub

* Add tests for ActivityPub workers

* Add tests for FollowService

* Add tests for FavouriteService, UnfollowService and PostStatusService

* Add tests for ReblogService, BlockService, UnblockService, ProcessMentionsService

* Add tests for AuthorizeFollowService, RejectFollowService, RemoveStatusService

* Add tests for BatchedRemoveStatusService

* Deliver updates to a local account to ActivityPub followers

* Minor adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment