Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store remote votes URI #10158

Merged
merged 3 commits into from Mar 4, 2019

Conversation

@ThibG
Copy link
Collaborator

commented Mar 4, 2019

This is useful if we ever plan to support remote users deleting their votes.

@ThibG ThibG force-pushed the ThibG:fixes/store-vote-uri branch 3 times, most recently from e471ef9 to a866421 Mar 4, 2019
@ThibG ThibG force-pushed the ThibG:fixes/store-vote-uri branch 5 times, most recently from 41785d0 to b25f35a Mar 4, 2019
@ThibG ThibG force-pushed the ThibG:fixes/store-vote-uri branch from b25f35a to 05e528e Mar 4, 2019
@ThibG ThibG marked this pull request as ready for review Mar 4, 2019
@Gargron
Gargron approved these changes Mar 4, 2019
@Gargron Gargron merged commit 833ffce into tootsuite:master Mar 4, 2019
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Gargron added a commit that referenced this pull request Mar 5, 2019
Gargron added a commit that referenced this pull request Mar 5, 2019
* Fix ActivityPub poll results being serialized even with hide_totals

* Fix poll refresh button having a different font size

* Display poll in OpenGraph description

* Fix NoMethodError when serializing votes

Regression from #10158

* Fix polls on public pages being broken for non-logged-in users

* Do not show time remaining if poll has no expiration date
@ThibG ThibG deleted the ThibG:fixes/store-vote-uri branch Mar 14, 2019
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Store remote votes URI

* Add spec for accepting remote votes

* Make poll vote id generation work the same way as follows
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Fix ActivityPub poll results being serialized even with hide_totals

* Fix poll refresh button having a different font size

* Display poll in OpenGraph description

* Fix NoMethodError when serializing votes

Regression from tootsuite#10158

* Fix polls on public pages being broken for non-logged-in users

* Do not show time remaining if poll has no expiration date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.