Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues in polls #10165

Merged
merged 7 commits into from Mar 5, 2019

Conversation

@Gargron
Copy link
Member

commented Mar 4, 2019

  • Fix ActivityPub serializer exposing vote counts on hide_totals polls before expiration
  • Fix refresh button on polls having smaller font-size
  • Fix OpenGraph description missing poll text

@Gargron Gargron added the bug label Mar 4, 2019

Gargron added 4 commits Mar 5, 2019
Fix more issues with polls
- Fix NoMethodError when serializing votes
- Fix public pages with polls for non-logged-in users
- Fix display of remaining time when poll has no expiration date
@ykzts
ykzts approved these changes Mar 5, 2019

@Gargron Gargron merged commit a198add into master Mar 5, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the fix-polls-misc branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.