Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign landing page #10232

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Redesign landing page #10232

merged 1 commit into from
Mar 12, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Mar 10, 2019 •
edited
Loading

grafik

Design notes

  • Less busy layout
  • Reduce layout differences caused by various admin settings
  • Public timeline on a separate page in masonry layout, like the public hashtag page
  • Bite-sized tagline to communicate Mastodon's purpose
  • Prominent hint that you can talk to people from other servers
  • Prominent hint that mobile apps exist
  • More useful server stats: Only total registered and monthly active (MAU)
  • Server info and all custom content in one compact widget
  • Layout form always displayed to simplify returning users login
  • Prominent link to help with login issues

Progress

  • New design
  • Ensure it's responsive on smaller screens
  • Public timeline page similar to public hashtag page
  • Support local/federated admin setting
  • Support hiding timeline preview admin setting
  • Support hiding profile directory admin setting
  • Support closed registrations admin setting

Responsive design screenshots

Screen Shot 2019-03-12 at 01 14 58
Screen Shot 2019-03-12 at 01 15 05

Other notes

  • site_description is no longer displayed on the frontpage, specifically only site_short_description. This is because based on real-world examples, it would not fit into the hero widget, and would also contain a lot of information that is not urgent. Some parts of the code, especially the instance REST API, continue to use site_description
  • The registration form is now always displayed, but disabled when registrations are disabled. This is also a little bit of preparation for approval-based registrations mode which I promised

@Gargron Gargron added ui Front-end, design work in progress Not to be merged, currently being worked on labels Mar 10, 2019
@Gargron Gargron force-pushed the redesign-landing-page branch 7 times, most recently from 428aaad to d1b8dcb Compare March 11, 2019 16:43
@Gargron Gargron marked this pull request as ready for review March 11, 2019 16:54
@Gargron Gargron removed the work in progress Not to be merged, currently being worked on label Mar 12, 2019
@marek-lach
Copy link
Contributor

Liking it so far, 2 points about grammar corrections:

Browse a profile directory and filter by it, not ir

Try a mobile, or desktop app

@Aditoo17
Copy link
Contributor

Aditoo17 commented Mar 12, 2019 •
edited
Loading

Browse a profile directory and filter by it, not ir

It's actually "filter by interests", but that didn't fit on the mobile screen. See the desktop screenshot above to see it.

@Gargron Gargron merged commit 65fffea into master Mar 12, 2019
@Gargron Gargron deleted the redesign-landing-page branch March 12, 2019 16:34
@SnDer
Copy link

SnDer commented Mar 12, 2019

Is the logo on the landing page new or is there just some text added in code? "Follow friends and discover new ones"

@Gargron
Copy link
Member Author

Gargron commented Mar 12, 2019

Text added in code.

@mayaeh mayaeh mentioned this pull request Mar 13, 2019
Merged
@tribela
Copy link
Contributor

tribela commented Mar 18, 2019

closed_registrations_message also gone.

@nightpool nightpool mentioned this pull request Jun 7, 2019
Closed
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@Gargron @hiyuki2578
Redesign landing page (mastodon#10232)
d2b333b
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
@Gargron
Redesign landing page (mastodon#10232)
1b4c876
@ClearlyClaire ClearlyClaire mentioned this pull request Jan 13, 2022
Closed
@ClearlyClaire ClearlyClaire mentioned this pull request Jan 13, 2022
Merged
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this pull request Jan 13, 2022
@ClearlyClaire
Remove support for OAUTH_REDIRECT_AT_SIGN_IN
4030edd 
Fixes mastodon#15959

Introduced in mastodon#6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form
to instead redirect to the external OmniAuth login provider.

However, it did not prevent the log-in form on /about introduced by mastodon#10232 from
appearing, and completely broke with the introduction of mastodon#15228.

As I restoring that previous log-in flow without introducing a security
vulnerability may require extensive care and knowledge of how OmniAuth works,
this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time
being.
@ClearlyClaire ClearlyClaire mentioned this pull request Jan 14, 2022
Merged
3 tasks
Gargron pushed a commit that referenced this pull request Jan 23, 2022
@ClearlyClaire
Remove support for OAUTH_REDIRECT_AT_SIGN_IN (#17287)
cfa583f 
Fixes #15959

Introduced in #6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form
to instead redirect to the external OmniAuth login provider.

However, it did not prevent the log-in form on /about introduced by #10232 from
appearing, and completely broke with the introduction of #15228.

As I restoring that previous log-in flow without introducing a security
vulnerability may require extensive care and knowledge of how OmniAuth works,
this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time
being.
Gargron pushed a commit that referenced this pull request Jan 23, 2022
@ClearlyClaire
Add OMNIAUTH_ONLY environment variable to enforce externa log-in (#17288
bddd9ba 
)

* Remove support for OAUTH_REDIRECT_AT_SIGN_IN

Fixes #15959

Introduced in #6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form
to instead redirect to the external OmniAuth login provider.

However, it did not prevent the log-in form on /about introduced by #10232 from
appearing, and completely broke with the introduction of #15228.

As I restoring that previous log-in flow without introducing a security
vulnerability may require extensive care and knowledge of how OmniAuth works,
this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time
being.

* Add OMNIAUTH_ONLY environment variable to enforce external log-in only

* Disable user registration when OMNIAUTH_ONLY is set to true

* Replace log-in links When OMNIAUTH_ONLY is set with exactly one OmniAuth provider
jesseplusplus pushed a commit to jesseplusplus/decodon that referenced this pull request Feb 10, 2022
@ClearlyClaire @jesseplusplus
Remove support for OAUTH_REDIRECT_AT_SIGN_IN (mastodon#17287)
ac05d3d 
Fixes mastodon#15959

Introduced in mastodon#6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form
to instead redirect to the external OmniAuth login provider.

However, it did not prevent the log-in form on /about introduced by mastodon#10232 from
appearing, and completely broke with the introduction of mastodon#15228.

As I restoring that previous log-in flow without introducing a security
vulnerability may require extensive care and knowledge of how OmniAuth works,
this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time
being.
jesseplusplus pushed a commit to jesseplusplus/decodon that referenced this pull request Feb 10, 2022
@ClearlyClaire @jesseplusplus
Add OMNIAUTH_ONLY environment variable to enforce externa log-in (mas…
251711d 
…todon#17288)

* Remove support for OAUTH_REDIRECT_AT_SIGN_IN

Fixes mastodon#15959

Introduced in mastodon#6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form
to instead redirect to the external OmniAuth login provider.

However, it did not prevent the log-in form on /about introduced by mastodon#10232 from
appearing, and completely broke with the introduction of mastodon#15228.

As I restoring that previous log-in flow without introducing a security
vulnerability may require extensive care and knowledge of how OmniAuth works,
this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time
being.

* Add OMNIAUTH_ONLY environment variable to enforce external log-in only

* Disable user registration when OMNIAUTH_ONLY is set to true

* Replace log-in links When OMNIAUTH_ONLY is set with exactly one OmniAuth provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krainboltgreene krainboltgreene krainboltgreene approved these changes

Assignees
No one assigned
Labels
ui Front-end, design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Gargron @marek-lach @Aditoo17 @SnDer @tribela @krainboltgreene