Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show disappointed elephant if web UI crashes #10275

Merged
merged 8 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@Gargron
Copy link
Member

Gargron commented Mar 15, 2019

A less ambitious version of #9278 for the time being. Still better than an empty grey page.

@Gargron Gargron added the ui label Mar 15, 2019

@Gargron Gargron force-pushed the feature-error-boundary branch from 977491c to a9e5022 Mar 15, 2019

@Gargron Gargron force-pushed the feature-error-boundary branch from a9e5022 to 9e6615a Mar 15, 2019

@ykzts

ykzts approved these changes Mar 15, 2019

@Gargron Gargron merged commit c20d096 into master Mar 15, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the feature-error-boundary branch Mar 15, 2019

enewhuis added a commit to BrazosCC/mastodon that referenced this pull request Mar 15, 2019

Show disappointed elephant if web UI crashes (tootsuite#10275)
* Do not crash the whole UI when loading an invalid column

* Add error boundary component to catch Web UI crashes

* Add stack trace on supported browsers

* Add component stack info, pre-format everything for github

* Make “Reload” a clickable link that calls window.location.reload()

* Remove elephant friend from error boundary, make title stand out more

* Simplify error boundary to only a graphic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.