Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Dockerfile to bind to 0.0.0.0 instead of docker-compose.yml #11351

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@Gargron
Copy link
Member

commented Jul 18, 2019

Since there is no real way to use these things from Docker if they don't bind to 0.0.0.0, the interface should be defined in the Dockerfile instead of being overriden in the docker-compose.yml file. This helps people who may run Docker containers with a different tool.

@Gargron Gargron added the bug label Jul 18, 2019

@ThibG

ThibG approved these changes Jul 18, 2019

@Gargron Gargron merged commit 15c7478 into master Jul 18, 2019

2 checks passed

build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details

@Gargron Gargron deleted the fix-docker-compose-streaming branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.