Fix trending counter width #11569
Merged
Fix trending counter width #11569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trending counter used to be constant 100px in width, which caused issues in languages like Russian, where because of that, "talking" text was cut to the size where actual count is not visible at all: > 6 people talking > Популярно у...
|
Hope did everything right 😟 Screenshots for reference:
Tested with Firefox: CSS changes.trends__item__current {
- width: 100px;
+ margin-left: 5px;
} |
ykzts
approved these changes
Aug 15, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
Trending counter used to be constant 100px in width, which caused issues in languages like Russian, where because of that, "talking" text was cut to the size where actual count is not visible at all: > 6 people talking > Популярно у...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trending counter used to be constant 100px in width, which caused
issues in languages like Russian, where because of that, "talking"
text was cut to the size where actual count is not visible at all: