Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin setting to opt out of search engine indexing by default #11804

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@brortao
Copy link
Contributor

commented Sep 10, 2019

fixes #11750.

this is my first time working with both ruby and rails so i'm not quite sure where to put a test for this. i'd appreciate it if someone could point me in the right direction for that :)

testing the view for the noindex meta tag might be nice, but as far as i can tell things aren't really set up for that kind of integration testing?

@Gargron Gargron changed the title add admin setting to opt out of search engine indexing by default Add admin setting to opt out of search engine indexing by default Sep 11, 2019

@Gargron Gargron merged commit 4fe1276 into tootsuite:master Sep 11, 2019

2 checks passed

build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
@Shleeble

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Why is opt-in the default? Shouldn't we opt out?

@Gargron

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

No, the default expectation for social media profiles is that they are findable. If I type in "eugen rochko linkedin" into Google I expect to see my profile rather than go and enable it separately in the innards of LinkedIn's settings area. If you think that that is not the expectation for your own community, that is why you now have this admin setting to control it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.