Fix “slow mode” issues #11859
Merged
Fix “slow mode” issues #11859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ClearlyClaire
commented
Sep 16, 2019
ClearlyClaire
commented
- Do not scroll weirdly when clicking the “load pending items” button
- Treat pending items as unread items
|
The “X new items” click was interfering with the mouse movement scroll prevention behavior, which resulted in very weird scroll behavior. I fixed that. |
|
Is the mouse movement thing still necessary if scrolling down will add new stuff to pending items instead of pushing the feed down? |
|
yes, if you're still on top |
Gargron
approved these changes
Sep 16, 2019
ClearlyClaire
force-pushed
the
fixes/pending-items
branch
from
0b574cc
to
0b1041f
Compare
|
Pushed another commit preventing a scroll discrepancy I hadn't seen: when scrolled down and the “x new items” button appears, it pushed everything down and that wasn't corrected |
ponapalt
added a commit
to ponapalt/mastodon
that referenced
this pull request
Sep 16, 2019
ponapalt
added a commit
to ponapalt/mastodon
that referenced
this pull request
Sep 17, 2019
This reverts commit d28ca02 partially.
ponapalt
added a commit
to ponapalt/mastodon
that referenced
this pull request
Sep 17, 2019
This reverts commit d28ca02.
ponapalt
added a commit
to ponapalt/mastodon
that referenced
this pull request
Sep 17, 2019
…lly"" This reverts commit 82c4520.
ponapalt
added a commit
to ponapalt/mastodon
that referenced
this pull request
Sep 17, 2019
… partially""" This reverts commit c4bb702.
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Fix weird scroll-jumping behavior with pending items * Treat pending items as unread items * Fix scroll position being altered because of the “X new items” button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.