Use different strings on exports page #12569
Conversation
| %td= number_with_delimiter @export.total_statuses | ||
| %td | ||
| %tr | ||
| %th= t('exports.follows') |
There was a problem hiding this comment.
Why replace a string that seems to exist specifically for this page, though?
There was a problem hiding this comment.
It's kind of looks off with that “You” prefix being alongside with the ones above and below. And for prefix in general, I think it's redundant because the page itself is suggesting that it's your data to export, probably can remove it from the ones below too.
|
Hm, why did CI fail with complaint about unused key? I mean, yeah, there is such change. But I perfectly can see from search that this string is still being used in other files, so it's strange why it fails as unused. Probably cannot use direct access then and must duplicate the string, because I'm not sure there is a magic number that will fall to |
|
Okay, I have found |
Currently the page re-uses strings from other contexts which doesn't fit very well - strings incorrectly lowercase-d and pluralized, when they don't need to be, because it's a table. This commit changes page to re-use accounts.posts_tab_heading for toots, and admin.accounts for "Following" and "Follows". This all should look more aesthetically pleasing.
Currently the page re-uses strings from other contexts which doesn't fit very well - strings incorrectly lowercase-d and pluralized, when they don't need to be, because it's a table.
This PR changes page to re-use
accounts.toots.otherdirectly, andadmin.accountsfor "Following" and "Follows". This should look more aesthetically pleasing.I cannot set up local testing Mastodon instance, so please carefully review the changes or test them on your local instance. Thanks!