Upgrade .nvmrc to Node.js 12 #12906
Merged
Upgrade .nvmrc to Node.js 12 #12906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Jan 20, 2020
|
My commit pushed to nodejs 10. Do we want to push to packages to 12? |
|
Node.js 10 is still active and will reach its EOL in 2021. It should be fine to let users run that version until then. I jumped right to 12 since it works and so that we (probably) don't need to upgrade to an another major version until April 2022. (Even tho 14 is releasing in 3 months) |
|
works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove engine errors since #12791 by setting the latest LTS.