Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade .nvmrc to Node.js 12 #12906

Merged
merged 1 commit into from Jan 21, 2020
Merged

Upgrade .nvmrc to Node.js 12 #12906

merged 1 commit into from Jan 21, 2020

Conversation

@mkody
Copy link
Contributor

mkody commented Jan 20, 2020

This should remove engine errors since #12791 by setting the latest LTS.

@shleeable

This comment has been minimized.

Copy link
Contributor

shleeable commented Jan 20, 2020

My commit pushed to nodejs 10. Do we want to push to packages to 12?

@mkody

This comment has been minimized.

Copy link
Contributor Author

mkody commented Jan 20, 2020

Node.js 10 is still active and will reach its EOL in 2021. It should be fine to let users run that version until then.

I jumped right to 12 since it works and so that we (probably) don't need to upgrade to an another major version until April 2022. (Even tho 14 is releasing in 3 months)

@shleeable

This comment has been minimized.

Copy link
Contributor

shleeable commented Jan 21, 2020

works for me.

@Gargron Gargron merged commit b0acead into tootsuite:master Jan 21, 2020
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
@mkody mkody deleted the mkody:patch-1 branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.