Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming issue #13551

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Fix naming issue #13551

merged 1 commit into from
Apr 27, 2020

Conversation

mayaeh
Copy link
Contributor

@mayaeh mayaeh commented Apr 27, 2020

Fixes an issue where attachment media URL are incorrect in environments using the object storage. (ref: #12821 (comment))

I don't understand why this happens. If you have a better solution, please use that one.

@mayaeh
Copy link
Contributor Author

mayaeh commented Apr 27, 2020

I understand that url_prefix and prefix_url have completely different meanings.
I can't think of a better name...

@zunda
Copy link
Contributor

zunda commented Apr 27, 2020

This fixed the problem for my server 👍

@Gargron Gargron merged commit acc367f into mastodon:master Apr 27, 2020
@mayaeh mayaeh deleted the fix_12821 branch April 27, 2020 08:54
@ClearlyClaire
Copy link
Contributor

I don't understand why this happens.

My guess is that :url and :path may already interpolated, before :url_prefix and :path_prefix get a chance to be replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mayaeh @zunda @ClearlyClaire @Gargron