Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump doorkeeper from 5.3.1 to 5.3.2 #13613

Merged
merged 1 commit into from
May 7, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented May 5, 2020

Bumps doorkeeper from 5.3.1 to 5.3.2. This update includes a security fix.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Doorkeeper application secret information disclosure vulnerability Information disclosure vulnerability. Allows an attacker to see all Doorkeeper::Application model attribute values (including secrets) after authorizing an application to their user.

An application is vulnerable if the authorized applications controller is enabled (GET /oauth/authorized_applications.json).

Recommended additional hardening for >= 5.1 is to enable application secrets hashing. This would render the exposed secret useless.

Patched versions: ~> 5.0.3; ~> 5.1.1; ~> 5.2.5; >= 5.3.2 Unaffected versions: < 5.0.0

Release notes

Sourced from doorkeeper's releases.

v5.3.2

  • #1371 Backport: Add #as_json method and attributes serialization restriction for Application model. Fixes information disclosure vulnerability (CVE-2020-10187).
Changelog

Sourced from doorkeeper's changelog.

5.3.2

  • #1371 Backport: add #as_json method and attributes serialization restriction for Application model. Fixes information disclosure vulnerability (CVE-2020-10187).
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [doorkeeper](https://github.com/doorkeeper-gem/doorkeeper) from 5.3.1 to 5.3.2. **This update includes a security fix.**
- [Release notes](https://github.com/doorkeeper-gem/doorkeeper/releases)
- [Changelog](https://github.com/doorkeeper-gem/doorkeeper/blob/master/CHANGELOG.md)
- [Commits](doorkeeper-gem/doorkeeper@v.5.3.1...v5.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code security Security issues and fixes, vulnerabilities labels May 5, 2020
@ykzts
Copy link
Sponsor Member

ykzts commented May 7, 2020

@dependabot rebase

@dependabot-preview
Copy link
Contributor Author

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@ykzts
Copy link
Sponsor Member

ykzts commented May 7, 2020

@dependabot recreate

@Gargron Gargron merged commit 51dad92 into master May 7, 2020
@Gargron Gargron deleted the dependabot/bundler/doorkeeper-5.3.2 branch May 7, 2020 18:16
@zunda
Copy link
Contributor

zunda commented May 7, 2020

This might have broken some part of my server.

When posting a toot:

NoMethodError (private method `read_attribute_for_serialization' called for #<Doorkeeper::Application:0x00007f842ccb98c0>
ation):

app/controllers/api/v1/statuses_controller.rb:51:in `create'
app/controllers/concerns/rate_limit_headers.rb:10:in `block in override_rate_limit_headers'
heroku[router]: at=info method=POST path="/api/v1/statuses" connect=17ms service=148ms status=500 bytes=1295 protocol=https

Also, notifications and detail for a toot disappeared:

Screenshot_2020-05-07_08-40-07

reverting to see if it fixes.

zunda added a commit to zunda/mastodon that referenced this pull request May 7, 2020
zunda added a commit to zunda/mastodon that referenced this pull request May 7, 2020
Gargron added a commit that referenced this pull request May 10, 2020
There are no obvious ways it could be misused, as the secret is not
really used for anything, but it is best to secure it for the future

Follow-up to #13613
Gargron added a commit that referenced this pull request May 10, 2020
…13688)

There are no obvious ways it could be misused, as the secret is not
really used for anything, but it is best to secure it for the future

Follow-up to #13613
shouo1987 pushed a commit to CrossGate-Pawoo/mastodon that referenced this pull request May 19, 2020
…astodon#13688)

There are no obvious ways it could be misused, as the secret is not
really used for anything, but it is best to secure it for the future

Follow-up to mastodon#13613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code security Security issues and fixes, vulnerabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants