Switch from deprecated ClusterWS/cws to ws package #15932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoboten
approved these changes
Mar 22, 2021
diegoboten
approved these changes
Mar 22, 2021
diegoboten
approved these changes
Mar 22, 2021
diegoboten
approved these changes
Mar 22, 2021
diegoboten
approved these changes
Mar 22, 2021
diegoboten
approved these changes
Mar 22, 2021
ykzts
approved these changes
Mar 23, 2021
ykzts
reviewed
Mar 23, 2021
ykzts
reviewed
Mar 23, 2021
|
ws supports nodejs 14. which is nice. |
Fixes mastodon#15184 Co-authored-by: Edho Arief <me@nanaya.pro>
Gargron
added a commit
that referenced
this pull request
May 1, 2021
Third argument of `ping` is the callback Regression from #15932
Gargron
added a commit
that referenced
this pull request
May 2, 2021
Third argument of `ping` is the callback Regression from #15932
erictapen
added a commit
to erictapen/nixpkgs
that referenced
this pull request
May 17, 2021
mastodon/mastodon#15932 got closed in Mastodon 3.4.0.
erictapen
added a commit
to NixOS/nixpkgs
that referenced
this pull request
May 21, 2021
mastodon/mastodon#15932 got closed in Mastodon 3.4.0.
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
* Switch from deprecated ClusterWS/cws to ws package Fixes mastodon#15184 Co-authored-by: Edho Arief <me@nanaya.pro> * Make bufferutil and utf-8-validate optional dependencies Co-authored-by: Edho Arief <me@nanaya.pro>
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
) Third argument of `ping` is the callback Regression from mastodon#15932
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15184, #15898
Code changes from #15184 (comment) rebased over latest code
I have verified this to work correctly with just a few connections on a mostly-single-user instance, but I did not make any performance measurement, and I am not quite sure how to go about doing those.