-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from deprecated ClusterWS/cws to ws package #15932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this resolved the issue for mastodon-streaming and is now working correctly on my server. (Ubuntu 20.4) Thank you so much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm correct operation of mastodon-streaming following these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This corrects the issue.
ws supports nodejs 14. which is nice. |
Fixes mastodon#15184 Co-authored-by: Edho Arief <me@nanaya.pro>
Third argument of `ping` is the callback Regression from #15932
Third argument of `ping` is the callback Regression from #15932
mastodon/mastodon#15932 got closed in Mastodon 3.4.0.
mastodon/mastodon#15932 got closed in Mastodon 3.4.0.
* Switch from deprecated ClusterWS/cws to ws package Fixes mastodon#15184 Co-authored-by: Edho Arief <me@nanaya.pro> * Make bufferutil and utf-8-validate optional dependencies Co-authored-by: Edho Arief <me@nanaya.pro>
) Third argument of `ping` is the callback Regression from mastodon#15932
Fixes #15184, #15898
Code changes from #15184 (comment) rebased over latest code
I have verified this to work correctly with just a few connections on a mostly-single-user instance, but I did not make any performance measurement, and I am not quite sure how to go about doing those.