Fix newlines in accout notes added by the Move handler #16415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Jun 23, 2021
Gargron
pushed a commit
that referenced
this pull request
Nov 5, 2021
* Fix newlines in account notes added by the move handler * Make MoveWorker more robust
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 6, 2021
* Fix newlines in account notes added by the move handler * Make MoveWorker more robust
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 7, 2021
* Fix newlines in account notes added by the move handler * Make MoveWorker more robust
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jan 28, 2022
* Fix newlines in account notes added by the move handler * Make MoveWorker more robust
jesseplusplus
pushed a commit
to jesseplusplus/decodon
that referenced
this pull request
Feb 10, 2022
* Fix newlines in account notes added by the move handler * Make MoveWorker more robust
jesseplusplus
pushed a commit
to jesseplusplus/decodon
that referenced
this pull request
May 18, 2022
* Fix newlines in account notes added by the move handler * Make MoveWorker more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's also some defensive programming stuff to avoid an error affecting one account from affecting other accounts.
Indeed, I have had a report about some behavior that I can only explain by the
Moveworker failing midway in eithercopy_account_notes!orcarry_blocks_over!, but I have not had access to that server's logs yet, so I don't know what happened exactly. This change would not have fixed the underlying cause, but it would have made it so it didn't prevent the block from carrying over.