Improve shared status verification #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to purported original URL. Confirm that the "original" URL is from the same domain as the author it claims to be from.
ashfurrow
reviewed
Apr 27, 2017
| return FollowRemoteAccountService.new.call("#{username}@#{domain}") | ||
| account = FollowRemoteAccountService.new.call("#{username}@#{domain}") | ||
|
|
||
| return nil if confirmed_domain?(domain, account) |
There was a problem hiding this comment.
This doesn't quite read right to me, return nil if the domain is confirmed? If it's correct, a clarifying comment could be helpful 👍
mjankowski
reviewed
Apr 27, 2017
…ests per Webfinger lookup
seefood
pushed a commit
to Toootim/mastodon
that referenced
this pull request
Apr 28, 2017
* Instead of parsing shared status contents verbatim, make roundtrip to purported original URL. Confirm that the "original" URL is from the same domain as the author it claims to be from. * Fix obvious typo, add comment * Use URI look-up first * Add test, update Goldfinger dependency to make less useless HTTP requests per Webfinger lookup
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of parsing shared status contents verbatim, make roundtrip to purported original URL. Confirm that the "original" URL is from the same domain as the author it claims to be from.