Implement hash tag completion #3196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return [null, null]; | ||
| } | ||
|
|
||
| word = word.trim().toLowerCase().slice(1); |
There was a problem hiding this comment.
why remove this?
will it make the matching case sensitive? do we want that?
There was a problem hiding this comment.
I thought the hashtag would distinguish between uppercase and lowercase letters.
I found it to be all lowercase so fixed it.
|
resolve conflicts. |
orekyuu
force-pushed
the
hash-tag-completion
branch
from
6d9fe94
to
646dbb5
Compare
orekyuu
force-pushed
the
hash-tag-completion
branch
from
646dbb5
to
4685a2b
Compare
nolanlawson
suggested changes
May 31, 2017
| localStorage.setItem('hash_tag_history', data); | ||
| } catch (e) { | ||
| //ignore | ||
| } |
There was a problem hiding this comment.
Storing large amounts of data in LocalStorage is inefficient. I'd advise using IDB instead via a library like Dexie. You can also use it for range queries, meaning you don't need to constantly re-parse a big string of JSON and then search through it using JavaScript.
|
@orekyuu ping |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements completion of hashtags.
The tooted hashtag is included in the candidate.
Candidates are stored localStorage.