Set default From address in config #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation sets default From address in mailers. It sets the address from SMTP_FROM_ADDRESS, or notifications@localhost. The behavior is occasionally undesired results. In production environment, notifications@localhost is likely to be incorrect. In testing environment, the email address should not be varied by a environment variable. After appling this change, In production environment, it will throw an exception when launching Mastodon. In testing environment, the address will be fixed with notifications@localhost.
akihikodaki
added
the
deployment
mjankowski
approved these changes
Jun 29, 2017
|
So this breaks upgrades on Scalingo (and probably all “serverless”/buildpack-based systems?) In attempting to upgrade from 1.4.7 to 1.5.1 on Scalingo via git push, I’m getting: “KeyError: key not found: "SMTP_FROM_ADDRESS"“ |
|
Workaround to install updates following this merge:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation sets default
Fromaddress in mailers. It sets the address fromSMTP_FROM_ADDRESS, ornotifications@localhost. The behavior is occasionally undesired results.In production environment,
notifications@localhostis likely to be incorrect.In testing environment, the email address should not be varied by a environment variable.
After appling this change,
In production environment, it will throw an exception when launching Mastodon.
In testing environment, the address will be fixed with
notifications@localhost.