Improve admin page #4121
Merged
Improve admin page #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcang
force-pushed
the
improve_admin_page
branch
from
c36dfdc
to
7fa0897
Compare
ykzts
previously requested changes
Jul 9, 2017
| @form = Form::StatusBatch.new(form_status_batch_params) | ||
| unless @form.save | ||
| flash[:alert] = t('admin.statuses.failed_to_execute') | ||
| end |
There was a problem hiding this comment.
flash[:alert] = t('admin.statuses.failed_to_execute') unless @form.save
| flash[:alert] = t('admin.statuses.failed_to_execute') | ||
| end | ||
| redirect_to admin_account_statuses_path(@account.id, current_params) | ||
| end |
There was a problem hiding this comment.
flash[:alert] = t('admin.statuses.failed_to_execute') unless @form.save
| @@ -15,7 +23,7 @@ def update | |||
| def destroy | |||
| authorize @status, :destroy? | |||
| RemovalWorker.perform_async(@status.id) | |||
| redirect_to admin_report_path(@report) | |||
| render json: @status | |||
There was a problem hiding this comment.
|
I Improved select style |
mkljczk
reviewed
Jul 13, 2017
| batch: | ||
| delete: Delete | ||
| nsfw_off: NSFW OFF | ||
| nsfw_on: NSFW ON |
There was a problem hiding this comment.
NSFW? Isn't it now called 'Content warning' on Mastodon?
There was a problem hiding this comment.
"Content warning" is a function to hide sentences, and NSFW is a function to hide images. The implemented function is a function to change NSFW.
abcang
added a commit
to pixiv/mastodon
that referenced
this pull request
Jul 24, 2017
* Improve admin page * Fix test * Add spec * Improve select style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report page:
Account status page:
Account page:
