Redesign extended information page #4322
Conversation
Gargron
force-pushed
the
feature-redesign-about-more
branch
from
4c06bee
to
61c3928
Compare
| background: darken($ui-base-color, 4%); | ||
| padding: 40px 0; | ||
|
|
||
| .panel { |
There was a problem hiding this comment.
mostly just a comment, but the heavily nested scss style is much harder to read and maintain then the BEM style we use in the rest of the app. it makes it harder to override the content on the instance-owner side as well.
There was a problem hiding this comment.
Not sure how much you want to fix here, I'm not asking for you to rewrite the whole about.scss file. but moving some of the smaller comments to it would be nice.
There was a problem hiding this comment.
Well this is reusing classes that were already in here. I'm not adding anything new.
app/javascript/styles/about.scss
Outdated
| font-size: 14px; | ||
| line-height: 24px; | ||
| font-weight: 500; | ||
| color: lighten($ui-base-color, 26%); |
There was a problem hiding this comment.
we use this lighten(ui-base, 26%) a ton of places in this code and in the other about page code, it should be pulled out into a scss variable.
There was a problem hiding this comment.
Maybe, but that's a refactoring task.
There was a problem hiding this comment.
Right, but this PR is adding new uses of it.
Gargron
force-pushed
the
feature-redesign-about-more
branch
from
0b47839
to
f3923e6
Compare
When contact information is not set:
When contact information is set:
Mobile:
Textual changes: