Reduce wasted renders for column_loading.js #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Sep 20, 2017
| @@ -3,17 +3,25 @@ import PropTypes from 'prop-types'; | |||
|
|
|||
| import Column from '../../../components/column'; | |||
| import ColumnHeader from '../../../components/column_header'; | |||
| import ImmutablePureComponent from 'react-immutable-pure-component'; | |||
There was a problem hiding this comment.
I tried React.PureComponent but for some reason that resulted in more wasted renders than ImmutablePureComponent.
unarist
approved these changes
Sep 20, 2017
ykzts
reviewed
Sep 20, 2017
| render() { | ||
| let { title, icon } = this.props; | ||
| title = title || ''; | ||
| icon = icon || ''; |
There was a problem hiding this comment.
const { title = '', icon = '' } = this.props;Is it not acceptable in the above writing style?
There was a problem hiding this comment.
Ah...
static propTypes = {
title: PropTypes.oneOfType(PropTypes.node, PropTypes.string),
icon: PropTypes.string,
};
static defaultProps = {
title: '',
icon: '',
};The above may be better.
ykzts
reviewed
Sep 20, 2017
| }; | ||
|
|
||
| render() { | ||
| let { title, icon } = this.props; |
rutan
pushed a commit
to rutan/mastodon
that referenced
this pull request
Oct 11, 2017
* Reduce wasted renders for column_loading.js * Use defaultProps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces some wasted time for this component, as shown in this
ReactPerf.printWasted()before and after:(Scenario: load the local timeline in mobile view.)