Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send streaming API delete to people mentioned in status #5103

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Send streaming API delete to people mentioned in status #5103

merged 1 commit into from
Sep 25, 2017

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Sep 25, 2017

  • Previously they wouldn't receive it unless they were author's followers
  • Skip unpush from public/hashtag timelines if status wasn't public in the first place

@Gargron Gargron added api REST API, Streaming API, Web Push API bug Something isn't working labels Sep 25, 2017
@Gargron Gargron force-pushed the fix-delete-notifications-unpush branch from c3abecf to 9f76a0c Compare September 25, 2017 21:56
@Gargron
Send streaming API delete to people mentioned in status
2b91520 
- Previously they wouldn't receive it unless they were author's
  followers
- Skip unpush from public/hashtag timelines if status wasn't
  public in the first place
@Gargron Gargron force-pushed the fix-delete-notifications-unpush branch from 9f76a0c to 2b91520 Compare September 25, 2017 21:58
@Gargron Gargron merged commit 91e5b0d into master Sep 25, 2017
@Gargron Gargron deleted the fix-delete-notifications-unpush branch September 25, 2017 22:29
rutan pushed a commit to rutan/mastodon that referenced this pull request Oct 11, 2017
@Gargron @rutan
Send streaming API delete to people mentioned in status (mastodon#5103)
b5dfbc9 
- Previously they wouldn't receive it unless they were author's
  followers
- Skip unpush from public/hashtag timelines if status wasn't
  public in the first place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
api REST API, Streaming API, Web Push API bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gargron @ykzts