Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflowing in web UI #5246

Merged
merged 2 commits into from
Oct 6, 2017
Merged

Conversation

lynlynlynx
Copy link
Contributor

@lynlynlynx lynlynlynx commented Oct 6, 2017

  • It is needed to re-set text-overflow and overflow in display: block; .
    With this commit, all overflowing problems are solved! 🎉

Screenshot ( I use "THISISATESTFORVERYLONGUSERNAME", 30 letters.)
ba26

  • Fix: dropdown menu modal overflows outside the edge of the browser.

Before and after screenshots
ba27
Of course, modal sizing works properly.
ws000107

@lynlynlynx
Copy link
Contributor Author

Unfortunately, max-width: max-content; property is not yet supported in Edge.
I reverted fixing overflowing dropdown menu modal.

@nightpool
Copy link
Member

nightpool commented Oct 6, 2017

Can we use the max-content anyway? does is break on edge or is it just not supported? If it's absolutely necessary, can we use @supports(max-width: max-content) to gate this?

@nightpool
Copy link
Member

display: block;
overflow: hidden;
text-overflow: ellipsis;

seems like it's getting repeated a lot of places. Maybe it makes sense to make a mixin rule?

@Gargron Gargron merged commit 5a2c7bd into mastodon:master Oct 6, 2017
@lynlynlynx
Copy link
Contributor Author

@nightpool thanks for your comments.
max-width breaks styles on Edge, and it is not a fundamental way, so i look for another.
Repeating a lot, thats right, ill try to organize them with mixins before long

@lynlynlynx lynlynlynx deleted the fix-overflow-web branch October 6, 2017 18:52
rutan pushed a commit to rutan/mastodon that referenced this pull request Oct 11, 2017
* Fix overflowing in web UI

* Revert fixing dropdown menu modal
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017
* Fix overflowing in web UI

* Revert fixing dropdown menu modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants