New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar Emoji #5315
Avatar Emoji #5315
Conversation
Currently it can be used in status text. |
I don't have time/energy to review this and include it in 2.0.0, just saying. But it might come in after that. |
I think this feature works well with instances only for emoji registration purpose (e.g. https://moji.m.to/). We can reuse fetching/updating mechanisms of profile to get/update emojis. |
Is there any progress on that matter ? @utam0k what do you think about my design suggestion ? |
@Aldarone |
@Gargron Please tell me more your opinion. |
If you've put a 👎 or 😕 on this PR, I'd like to hear in text why. Assuming that the code for this feature is clean, I don't see much harm in supporting it, especially if some instances in the wild already support it (friends.nico) On the other hand, it's a bit strange, because these should count as mentions, shouldn't they? It's a bit unusual that you could just use someone's profile picture as an emoji without any permission or knowledge of the user. I don't know so I would appreciate extra feedback. |
I saw this in the federated timeline a couple of times coming from friends.nico and it's interesting, don't think I would use it, but I agree that maybe it should be a mention too. Seems to me you're @-ing the user, just using an emoji instead. |
I expect this feature is useful, but I am still not for this change because:
1. Why do we have to introduce a new syntax and federation protocol just for avatar emojis? Are we going to add new syntax every time we add emojis from different kind source? A syntax introduced in suc a way will not have backward compatibility, and make the implementation complex. 2. It is easy to allow everyone to use avatars of anyone else as emojis, but I suspect some people do not want that. Maybe we could make the option opt-in (NOT opt-out. Opt-out may not work for older versions of Mastodon and new federation implementations, and it is hard to notice the feature for users on such implementations.) However, it also raises a different question: who bothers to opt-in the feature? 3. I have seen some people launched instances to create their own emojis, but then abandoned. Creating accounts is an easier option for such people to create emojis and yet polluting the network. |
I see Aki's point and I am inclined to agree. Sorry @utam0k! 😢 |
AvatarEmoji is a custom emoji used Account's avatar.
It uses metadata of short_code, url, static_url like CustomEmoji.
shortcode is
@username
, url isavatar.original_url
, static_url isavatar.static_url
.When tooting with
:@username:
, it changes to avatar of that user.Unlike CustomEmoji, AvatarEmoji uses existing resources.
Therefore, it is not necessary to add or register emojis.
It has already been introduced in friends.nico and actually used.
In this PullReq, not only friends.nico but also AvatarEmoji is available for all instances.
https://friends.nico/@utam0k/37459454
https://friends.nico/@utam0k/37101753
https://friends.nico/@utam0k/36949650