Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling of dropdown when offscreen #5434

Merged
merged 1 commit into from Oct 17, 2017

Conversation

nolanlawson
Copy link
Contributor

This is a very small fix, but it appears to allow the body to scroll for both the status dropdown and the emoji dropdown when they extend offscreen:

screenshot 2017-10-17 08 03 00

screenshot 2017-10-17 08 27 50

Here's a video showing what it looks like in Firefox on macOS.

I tested this in Firefox, Edge, Chrome, and Safari, I tested modals and fullscreen videos, I tested mobile viewport sizes, and everything seems good to me. But I may have missed something, so I would appreciate a thorough review from someone else, since this changes a style on the entire body element and so may have some other effect I'm not aware of.

@nolanlawson
Copy link
Contributor Author

OK this is live on https://malfunctioning.technology, asking people to help test…

@nolanlawson
Copy link
Contributor Author

I think long-term we should probably do a redesign where the tooltip is either 1) contained to the column, so it scrolls with the column, or 2) automatically adjusts below/above/to the right of the target based on available space, or 3) both. For the time being though this seems like a stopgap solution.

I tested on Edge/Chrome/Firefox on Win10 and it seems same as Mac, mobile browsers appear unaffected since everything is modals instead of dropdowns.

@Gargron Gargron merged commit 8b22a63 into mastodon:master Oct 17, 2017
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants