Better pagination for ActivityPub outbox #7356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
added
work in progress
ClearlyClaire
approved these changes
May 4, 2018
abcang
pushed a commit
to pixiv/mastodon
that referenced
this pull request
May 22, 2018
abcang
added a commit
to pixiv/mastodon
that referenced
this pull request
May 22, 2018
Better pagination for ActivityPub outbox (mastodon#7356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mastodon fetches these collections only to read
totalItemsnumber. We can improve performance by not includingitemsdirectly in the collection, but instead usingfirstto link to a CollectionPage. Also, this adds proper, discoverable pagination.Fix #7204
This improves outbox (and removes unused pagination code from collections). See #7357 for following/followers.