New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick links to the admin interface in the WebUI #8545

Merged
merged 4 commits into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@ThibG
Copy link
Collaborator

ThibG commented Aug 31, 2018

This adds quick links at the bottom of the status/account dropdown menus if the logged-in user is a moderator.

Also an admin view for select toots only:
screenshot_2018-08-31 account statuses - thib sitedethib com - dev instance

@ThibG ThibG added the admin support label Aug 31, 2018

@ThibG ThibG force-pushed the ThibG:features/admin-links branch from 1b6962c to 2cf5ef3 Aug 31, 2018

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Aug 31, 2018

CircleCI is stuck for some reason…

@ThibG ThibG requested a review from Gargron Sep 13, 2018

@ThibG ThibG force-pushed the ThibG:features/admin-links branch from 2cf5ef3 to e705b64 Oct 11, 2018

authorize :status, :index?

@statuses = @account.statuses.where(id: params[:id])
authorize @statuses[0], :show?

This comment has been minimized.

@Gargron

Gargron Jan 4, 2019

Member

I suggest @statuses.first


%hr.spacer/

= form_for(@form, url: admin_account_statuses_path(@account.id)) do |f|

This comment has been minimized.

@Gargron

Gargron Jan 4, 2019

Member

Is this file not a carbon copy of something else? Could we reuse the existing template?

This comment has been minimized.

@ThibG

ThibG Jan 4, 2019

Author Collaborator

It's not an exact copy as there is no need for filters or pagination, but yeah, some refactoring is probably possible.

@ThibG ThibG force-pushed the ThibG:features/admin-links branch from e705b64 to 150b6fe Jan 4, 2019

ThibG added some commits Aug 31, 2018

Add admin links to status and account menus
If the current logged-in user is an admin, add quick links to the admin
interface in account and toot dropdown menu. Suggestion by @ashkitten

@ThibG ThibG force-pushed the ThibG:features/admin-links branch from 150b6fe to a2a661d Jan 4, 2019

@Gargron

Gargron approved these changes Jan 4, 2019

@Gargron Gargron merged commit 6f9a7bd into tootsuite:master Jan 4, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment