Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix a problem about generating an url of notifications #8758

Merged
merged 1 commit into from Sep 24, 2018

Conversation

@GenbuHase
Copy link
Contributor

commented Sep 22, 2018

Overview

It will be work well by adding base-url as a prefix.

@GenbuHase GenbuHase changed the title [Fix] Fix a problem about generating an url of notifications [Bugfix] Fix a problem about generating an url of notifications Sep 23, 2018
@nightpool

This comment has been minimized.

Copy link
Collaborator

commented Sep 24, 2018

not sure i quite follow. Even if we do fix the logic there, why doesn't it currently fall through to window.open on line 186?

@GenbuHase

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2018

@nightpool
Using URL constructor, 1st argument must be absolute path without a baseUrl as 2nd argument.

@Gargron Gargron merged commit 8b61683 into tootsuite:master Sep 24, 2018
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@GenbuHase GenbuHase deleted the Itabashi-don:fix/service_worker_notifys branch Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.