Move network calls out of transaction in ActivityPub handler #8951
Conversation
| end | ||
|
|
||
| def process_tags(status) | ||
| @params = begin |
There was a problem hiding this comment.
why begin here? shouldn't this just be @params = { ?
There was a problem hiding this comment.
Otherwise rubocop will require me to align the hash with the = which sucks. begin/end does nothing except improve the formatting.
There was a problem hiding this comment.
which rule was it? Layout/AlignHash definitely doesn't work that way. We should make sure to change the rubocop lint formatting when we run into a situation where it's behaving badly, so that we're consistent across PRs
There was a problem hiding this comment.
As far as I am aware we are required to:
hash = {
foo: bar,
baz: boo,
}Which looks bad.
There was a problem hiding this comment.
My understanding is that the default Layout/AlignHash and Layout/IndentHash rule should pass with this code:
hash = {
foo: bar,
baz: boo,
}
|
approve modulo formatting nits |
Mention and emoji code may perform network calls, but does not need to do that inside the database transaction. This may improve availability of database connections when using pgBouncer in transaction mode.
Gargron
force-pushed
the
fix-network-in-transaction
branch
from
542154a
to
16a884c
Compare
Mention and emoji code may perform network calls, but does not need
to do that inside the database transaction. This may improve availability
of database connections when using pgBouncer in transaction mode.