New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce usage of LD signatures #9659

Merged
merged 5 commits into from Dec 30, 2018

Conversation

Projects
None yet
2 participants
@ThibG
Copy link
Collaborator

ThibG commented Dec 30, 2018

LDS is used for forwarding replies and deletes, as well as for relays.
There is no need to LDS-sign “private” activities like Follow, Block etc., nor signing private toots.

Adding tests may be useful…

@ThibG ThibG force-pushed the ThibG:fixes/ld-sign branch from 900a18b to 41915ca Dec 30, 2018

@ThibG ThibG force-pushed the ThibG:fixes/ld-sign branch 2 times, most recently from ffb4272 to f7e92f1 Dec 30, 2018

@ThibG ThibG changed the title [WiP] Reduce usage of LD signatures Reduce usage of LD signatures Dec 30, 2018

@ThibG ThibG force-pushed the ThibG:fixes/ld-sign branch from f7e92f1 to 2ce99f7 Dec 30, 2018

@Gargron Gargron merged commit 2909326 into tootsuite:master Dec 30, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment