New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve e-mail digest #9689

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@Gargron
Copy link
Member

Gargron commented Jan 1, 2019

  • Reduce time-to-digest from 20 to 7 days
  • Fetch mentions starting from +1 day since last login
  • Fix case when last login is more recent than last e-mail
  • Do not render all mentions, only 40, but show number in subject
  • Do not send digest to moved accounts
  • Do send digest to silenced accounts

Fix case when last login is more recent than last e-mail

There is no bug report for this, but because the old code preferred last_emailed_at to current_sign_in_at, if you were ever e-mailed a digest due to absence, then came back, then would became inactive again, the digest would send you all mentions since that last e-mail, including all the mentions from the period you were active. I got a report of someone receiving a 6MB digest e-mail with over a thousand mentions.

@Gargron Gargron force-pushed the fix-digest-mailer branch 2 times, most recently from 46ec9dc to 8fb499a Jan 1, 2019

Improve e-mail digest
- Reduce time-to-digest from 20 to 7 days
- Fetch mentions starting from +1 day since last login
- Fix case when last login is more recent than last e-mail
- Do not render all mentions, only 40, but show number in subject
- Do not send digest to moved accounts
- Do send digest to silenced accounts

@Gargron Gargron force-pushed the fix-digest-mailer branch from 8fb499a to f49a056 Jan 1, 2019

@ykzts

ykzts approved these changes Jan 2, 2019

@Gargron Gargron merged commit 66436d0 into master Jan 2, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the fix-digest-mailer branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment