New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make draggingOver state off correctly #9797

Merged
merged 5 commits into from Jan 14, 2019

Conversation

Projects
None yet
3 participants
@hinaloe
Copy link
Contributor

hinaloe commented Jan 13, 2019

Sometimes, .upload-area could not close when dragging leave to out of window.

image

How to reproduce

  1. drag and drop any contents (Image, Text, and other) on Mastodon window (to same window).
  2. Try drag and drop any file from any file manager to Mastodon window, and cancel (non drop, or drop in original or other location).

Tested on

Chrome and Firefox (macOS, Linux)

Edge and Safari has the same problem reproducibility, but it does not seem to work well.
-> I found the simple way.

@hinaloe

This comment has been minimized.

Copy link
Contributor Author

hinaloe commented Jan 13, 2019

This seems to be related to #687

@hinaloe hinaloe changed the title make draggingOver state off correctly [WIP] make draggingOver state off correctly Jan 14, 2019

@hinaloe hinaloe changed the title [WIP] make draggingOver state off correctly make draggingOver state off correctly Jan 14, 2019

@ykzts

ykzts approved these changes Jan 14, 2019

@Gargron Gargron merged commit d6433b3 into tootsuite:master Jan 14, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@hinaloe hinaloe deleted the hinaloe:fix-dragleave branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment