Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS on OPTIONS method #85

Merged
merged 3 commits into from
Jun 2, 2013
Merged

CORS on OPTIONS method #85

merged 3 commits into from
Jun 2, 2013

Conversation

tooxie
Copy link
Owner

@tooxie tooxie commented May 31, 2013

Fixed the lack of CORS headers on OPTIONS request

@manutenfruits
Copy link
Contributor

I am still getting familiar with git, so sorry if this is not the most proper way of doing this.

There is also a header requested from chrome when trying to use the repository: X-Requested-With. Seems like apart from 'Access-Control-Allow-Headers:Content-Type' needs 'Access-Control-Allow-Headers:Content-Type, X-Requested-With' too.

I have added that too (sorry I forgot to mention that on the original issue) and now it works perfectly. I knew it just because Chrome suggested it, but here's some info about it: http://saltybeagle.com/2009/09/cross-origin-resource-sharing-demo/

@tooxie
Copy link
Owner Author

tooxie commented May 31, 2013

Added also Accept and Origin to the headers list, just in case.

@tooxie
Copy link
Owner Author

tooxie commented Jun 1, 2013

I would also like @slang800's opinion on this PR, because he introduced this feature in the first place.

@tooxie
Copy link
Owner Author

tooxie commented Jun 2, 2013

Thanks @manutenfruits for reporting this issue and @slang800 for the review! 👍

tooxie added a commit that referenced this pull request Jun 2, 2013
@tooxie tooxie merged commit fcb195d into master Jun 2, 2013
@tooxie tooxie deleted the cors-on-options branch June 2, 2013 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants