Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isn't shadow a performance killer? #461

Open
kof opened this issue Dec 13, 2013 · 6 comments
Open

Isn't shadow a performance killer? #461

kof opened this issue Dec 13, 2013 · 6 comments

Comments

@kof
Copy link

kof commented Dec 13, 2013

Hi

Topcoat seems to be a performance focused framework designed for mobile, but it still uses box and text shadows, which are known to cause performance issues on mobile devices.

What do you think?

Best,
Oleg

@GarthDB
Copy link
Member

GarthDB commented Dec 13, 2013

Oleg,

This is true. We've done quite a bit of work to remove unnecessary shadows, but the main theme uses them in the design. We have done some initial work on a flat theme that could be used and will have better mobile optimization.

Thanks,

Garth


Sent from Mailbox for iPhone

On Fri, Dec 13, 2013 at 3:47 AM, Oleg Slobodskoi notifications@github.com
wrote:

Hi
Topcoat seems to be a performance focused framework designed for mobile, but it still uses box and text shadows, which are known to cause performance issues on mobile devices.
What do you think?
Best,

Oleg

Reply to this email directly or view it on GitHub:
#461

@brianleroux
Copy link
Contributor

We def plan to have a flat theme. That said, we're benchmarking to ensure performance. Sometimes perf lore isn't accurate.

@kristoferjoseph
Copy link
Member

@kof Short answer YES.
Long answer How much slower?
Without benchmarks and a complete theme implemented we have nothing to compare against.
Flat theme in the works... it is FAF.

@kof
Copy link
Author

kof commented Dec 16, 2013

Its difficult to compare, for this you would need a worst case scenario + an old device ....

@kof
Copy link
Author

kof commented Dec 16, 2013

I mean animating lots of elements with shadows ....

@kristoferjoseph
Copy link
Member

True. We can get a baseline of performance impact from comparing the deltas of our current benchmarks. You are right though a comprehensive test would give device specific results. I'm OK with just knowing roughly what the tradeoff is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants