fix function _getAssignedResourceBooking()
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
reviewed
Dec 15, 2020
| async function searchResourceBookings (criteria) { | ||
| async function searchResourceBookings (criteria, options = { returnAll: false }) { | ||
| if (criteria.projectIds) { | ||
| if ((typeof criteria.projectIds) === 'string') { |
There was a problem hiding this comment.
Works great @imcaizheng. Just one minor thing.
Can we directly check for (typeof criteria.projectIds) === 'string' removing additional if (criteria.projectIds) { to keep things clear?
Or combine them into one if.
There was a problem hiding this comment.
@maxceem Of course we can remove the additional check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
GET /resourceBookingssupports a new parameter named "projectIds". The value for the parameter should be a list of project ids separated by commas. Both swagger document and postman collection are updated to reflect the change.searchResourceBookings(criteria)for the ResouceBookingService supports an additional argument which could be{ returnAll: true|false }.getTeamDetails()for the TeamService make use of the features listed above to search all assigned resources filtering by a list of project Ids.