Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration to be in a single spot #107

Closed
jmgasper opened this issue Oct 6, 2018 · 0 comments
Closed

Fix configuration to be in a single spot #107

jmgasper opened this issue Oct 6, 2018 · 0 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Oct 6, 2018

Problem

In attempting to fix a recent HTTPS issue, I had to make changes all over the place because we aren't consistent at all in our configuration.

The item I had to update was TC_USER_PROFILE_URL. I reconfigured it on Heroku and the bug persisted. I then fixed the same URL in src/common/constants.js and bug persisted. I then fixed the same URL in src/front/src/app/helper.js and the bug persisted. I eventually fixed the same URL in src/front/src/components/common/navigation.controller.js before the issue was resolved.

There's no reason why the same URL is created and configured in 4 or 5 spots in the app.

Fix

  • The configuration should all come from the environment.
  • No URLs should be created that are also configured.
  • All URLs should use https by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
October Release
  
Awaiting triage
Development

No branches or pull requests

1 participant