Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Confidence from float to double to align with global.c #35

Merged
merged 1 commit into from
May 26, 2021

Conversation

DavisVaughan
Copy link
Contributor

@DavisVaughan DavisVaughan commented May 24, 2021

This should fix this LTO warning

extern.h:72:14: warning: type of 'Confidence' does not match original declaration [-Wlto-type-mismatch]
   72 | extern float Confidence, SampleFrac, *Vote, *BVoteBlock, **MCost, **NCost,
      |              ^
global.c:138:8: note: type 'double' should match type 'float'
  138 | double Confidence; /* set by classify() */
      |        ^
global.c:138:8: note: 'Confidence' was previously declared here
global.c:138:8: note: code may be misoptimized unless '-fno-strict-aliasing' is used

It looks like it was supposed to be a double based on its usage in classify.c

@topepo topepo merged commit 3d8b755 into topepo:master May 26, 2021
@DavisVaughan DavisVaughan deleted the fix/lto branch January 28, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants