Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xyplot.resamples - dots not passed to xyplot #853

Closed
RonzoniInstitute opened this issue Mar 7, 2018 · 1 comment
Closed

xyplot.resamples - dots not passed to xyplot #853

RonzoniInstitute opened this issue Mar 7, 2018 · 1 comment

Comments

@RonzoniInstitute
Copy link

@RonzoniInstitute RonzoniInstitute commented Mar 7, 2018

Dots parameters (...) are not used in xyplot.resamples (I checked this only when what="scatter"). The issue seems to be that ... is not passed to xyplot here

out <- xyplot(tmpData[, 1] ~ tmpData[, 2], ylab = colnames(tmpData)[1], 
     xlab = colnames(tmpData)[2], xlim = ylm, ylim = ylm, 
     main = useMathSymbols(metric), panel = function(x, 
       y, ...) {
       panel.abline(0, 1, col = "darkgrey", lty = 2)
       panel.xyplot(x, y, ...)
     })

Please check the same issue also if other options are passed for the what argument.

Minimal, reproducible example:

If I add the cex=8 parameter to the example in the documentation for xyplot.resamples the plot doesn't change.

Minimal dataset:

library( caret )
load(url("http://topepo.github.io/caret/exampleModels.RData"))

Minimal, runnable code:

# From the documentation
xyplot(
  resamps,
  models = c("CART", "MARS"),
  metric = "RMSE"
)
# Nothing changes when setting cex=8
xyplot(
  resamps,
  models = c("CART", "MARS"),
  metric = "RMSE",
  cex=8
)

Session Info:

R version 3.4.3 (2017-11-30)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows >= 8 x64 (build 9200)

Matrix products: default

locale:
[1] LC_COLLATE=Italian_Italy.1252  LC_CTYPE=Italian_Italy.1252    LC_MONETARY=Italian_Italy.1252
[4] LC_NUMERIC=C                   LC_TIME=Italian_Italy.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] caret_6.0-78    ggplot2_2.2.1   lattice_0.20-35

loaded via a namespace (and not attached):
 [1] tidyselect_0.2.3   purrr_0.2.4        reshape2_1.4.3     kernlab_0.9-25     splines_3.4.3      colorspace_1.3-2  
 [7] stats4_3.4.3       yaml_2.1.16        survival_2.41-3    prodlim_1.6.1      rlang_0.1.6        ModelMetrics_1.1.0
[13] pillar_1.1.0       withr_2.1.1        foreign_0.8-69     glue_1.2.0         bindrcpp_0.2       foreach_1.4.4     
[19] bindr_0.1          plyr_1.8.4         dimRed_0.1.0       lava_1.6           robustbase_0.92-8  stringr_1.2.0     
[25] timeDate_3042.101  munsell_0.4.3      gtable_0.2.0       recipes_0.1.2      codetools_0.2-15   psych_1.7.8       
[31] parallel_3.4.3     class_7.3-14       DEoptimR_1.0-8     broom_0.4.3        Rcpp_0.12.15       scales_0.5.0      
[37] ipred_0.9-6        CVST_0.2-1         mnormt_1.5-5       stringi_1.1.6      dplyr_0.7.4        RcppRoll_0.2.2    
[43] ddalpha_1.3.1.1    grid_3.4.3         tools_3.4.3        magrittr_1.5       lazyeval_0.2.1     tibble_1.4.2      
[49] tidyr_0.8.0        DRR_0.0.3          pkgconfig_2.0.1    MASS_7.3-47        Matrix_1.2-12      lubridate_1.7.2   
[55] gower_0.1.2        assertthat_0.2.0   iterators_1.0.9    R6_2.2.2           rpart_4.1-11       sfsmisc_1.1-1     
[61] nnet_7.3-12        nlme_3.1-131       compiler_3.4.3  
topepo added a commit that referenced this issue Mar 9, 2018
@topepo
Copy link
Owner

@topepo topepo commented Mar 9, 2018

You are correct. I've fixed it. Thanks

@topepo topepo closed this Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.