Call the generic function instead of the method

[xrobin]

The upcoming pROC version 1.8 has a refactored NAMESPACE and won't allow direct calls to S3 methods. Instead, the generic function must be called. This fix is necessary to push fix xrobin/pROC#4 to CRAN.

Thanks!

[zachmayer]

👍 From me, if tests pass.

[coveralls]

Coverage remained the same at 2.42% when pulling 554b4ff on xrobin:master into cb00f95 on topepo:master.

[xrobin]

Thanks! Unfortunately it looks like a test failed...

Your test run exceeded 50 minutes.

Not sure if we're looking at a regression? There's one more dispatch call, but that can't be significant compared to the computations in the roc() function...

[zachmayer]

Yeah, I don't think that's you.  I'm going to take the vignette building out of the test code, that alone takes ~30 mins.

—
Sent from Mailbox

On Fri, Feb 27, 2015 at 12:02 PM, Xavier Robin notifications@github.com
wrote:

Thanks! Unfortunately it looks like a test failed...
Your test run exceeded 50 minutes.

Not sure if we're looking at a regression? There's one more dispatch call, but that can't be significant compared to the computations in the roc() function...

Reply to this email directly or view it on GitHub:
#125 (comment)

[topepo]

Thanks for helping out.

[xrobin]

Thanks, the tests with the new pROC version seem to pass now. Any idea when that fix will be available on CRAN?

[topepo]

I'll shoot for a new release in a 2-3 weeks.