Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documentations for lfda model #194

Merged
merged 8 commits into from
Aug 3, 2015
Merged

added documentations for lfda model #194

merged 8 commits into from
Aug 3, 2015

Conversation

terrytangyuan
Copy link
Contributor

No description provided.

@topepo
Copy link
Owner

topepo commented Jul 29, 2015

Do you need to add anything to the NAMESPACE file too? Also, please verify that everything is good by running R CMD BATCH --as-cran caret. There is a namespace issue reported related to this.

Thanks,

Max

@terrytangyuan
Copy link
Contributor Author

Hi Max, I have tried my best but I have no idea why it's still failing even though I fixed all the things the build log mentioned. It was failed earlier but now it was not completed due to some error. Could you take some time and help me with that?

Thanks,
Yuan

@terrytangyuan
Copy link
Contributor Author

I don't believe this error is caused by me. Maybe from your recent merge from pull request or something else?

@topepo
Copy link
Owner

topepo commented Jul 29, 2015

The Travis error is unrelated to your stuff. R CMD check --as-cran will
help figure out of the namespace stuff is correct and if there is any
issues with the documentation.

On Wed, Jul 29, 2015 at 2:50 PM, terrytangyuan notifications@github.com
wrote:

I don't believe this error is caused by me. Maybe from your recent merge
from pull request or something else?


Reply to this email directly or view it on GitHub
#194 (comment).

@terrytangyuan
Copy link
Contributor Author

It looks like the build on CRAN was successful but failed when not on CRAN. Also, the error is not from my documentation. Also, coverage is increased!

Could you check whether this PR can be merged?

@terrytangyuan
Copy link
Contributor Author

Hi Max, Can you check whether this is ready to be merged? I might want to add some unit test for lfda this week. Thanks.

topepo added a commit that referenced this pull request Aug 3, 2015
added documentations for lfda model
@topepo topepo merged commit 6b21181 into topepo:master Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants