Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBetter seeds (related to #349) #353
Merged
Conversation
Additional safety checks and calling sample.int just once to avoid possible repetition of seeds.
|
Excellent. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I added a couple of extra safety checks:
seedslistNAI also changed the strategy to create the seed list so that it calls
sample.intonly once. With the previous strategy there was a chance, however small, that a seed could be repeated. Unfortunately this means that any user who was using the default seed creation method would need to re-run the code to obtain the new reproducible result.Let me know if you agree with the changes.